Skip to content

Conversation

@VolodymyrBg
Copy link
Contributor

@VolodymyrBg VolodymyrBg commented Jul 13, 2025

Renamed BIGNUMNERISH_IMPORT to BIGNUMBERISH_IMPORT for consistency and to prevent confusion.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a typographical error in an internal constant used by the TypeScript code generator.
    • This corrects internal import handling in generated TypeScript interfaces and reduces potential generator warnings.
    • No user-facing behavior or public API changes; existing generated outputs and runtime behavior remain unchanged.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Ohayo sensei! Corrected a typographical constant name in the TypeScript generator: BIGNUMNERISH_IMPORT was renamed to BIGNUMBERISH_IMPORT. No other logic or behavior changed. (45 words)

Changes

Cohort / File(s) Change Summary
Constant rename
crates/dojo/bindgen/src/plugins/typescript/generator/constants.rs
Renamed pub(crate) const BIGNUMNERISH_IMPORTpub(crate) const BIGNUMBERISH_IMPORT (spelling fix).
Usage update
crates/dojo/bindgen/src/plugins/typescript/generator/interface.rs
Updated import and usage to reference BIGNUMBERISH_IMPORT instead of the misspelled name.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c69a076 and 6c657f1.

📒 Files selected for processing (1)
  • crates/dojo/bindgen/src/plugins/typescript/generator/interface.rs (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between acb476a and c69a076.

📒 Files selected for processing (1)
  • crates/dojo/bindgen/src/plugins/typescript/generator/constants.rs (1 hunks)

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, however you would need to update all references to this variable.

@glihm glihm marked this pull request as draft July 16, 2025 22:37
@VolodymyrBg
Copy link
Contributor Author

Thanks for spotting this, however you would need to update all references to this variable.

yes,it's done

@glihm glihm marked this pull request as ready for review September 9, 2025 21:03
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo fix.

@glihm glihm merged commit 2a1e1c7 into dojoengine:main Sep 9, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants