Do not show unnecessary steps for creating AOT-compatible OpenAPI application when running in .NET 10 - #34757
Merged
Merged
Conversation
…nning .NET 9 or lower I also removed the --prerelease flag from the package, no reason to add a prerelease version; AOT works fine without prerelease
Contributor
Author
|
Currently I've added I've looked through several commits to find out how I could set it to this preview-2 value, but I can't figure this out. If there's any changes required, let me know! |
Rick-Anderson
suggested changes
Feb 18, 2025
Contributor
Author
|
Important note: This should probably only get merged when dotnet/aspnetcore#60337 is merged. |
Rick-Anderson
marked this pull request as draft
February 19, 2025 23:31
Rick-Anderson
approved these changes
Feb 20, 2025
Rick-Anderson
left a comment
Contributor
There was a problem hiding this comment.
:::moniker range="= aspnetcore-9.0" is preferred over <10
sander1095
marked this pull request as ready for review
March 11, 2025 15:20
Contributor
Author
|
Hi @Rick-Anderson ! The main PR has been merged: dotnet/aspnetcore#60337 I've changed this PR's title and draft status, I believe it can be merged :)? |
Contributor
|
@sander1095 thanks so much for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have also removed the
--previewflag as it seems unnecessary. It's not necessary to add a preview package to get OpenAPI to be AOT compatible in .NET 9.Fixes #34756
Internal previews