Skip to content

[Pre5] Blazor What's New updates #35590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 10, 2025
Merged

[Pre5] Blazor What's New updates #35590

merged 10 commits into from
Jun 10, 2025

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Jun 6, 2025

Addresses #35473
Fixes #35361
Addresses #34870
Fixes #34893
Fixes #35278

Ilona

You only need to see the Not Found parts.

Pavel

Note to self (PU PRs): dotnet/aspnetcore#61516 and dotnet/aspnetcore#61609

The metrics part of this is still incomplete ...

Check the DIFF to see my progress.

  1. In terms of Blazor node coverage, is it OK to place the metrics coverage into the Blazor Perf Overview article (that's where I placed it thus far), or do you want a dedicated article for metrics and tracing?

The rest of these questions refer to the coverage going into the main doc set's built-in metrics article at ...

https://learn.microsoft.com/en-us/aspnet/core/log-mon/metrics/built-in?view=aspnetcore-9.0

  1. Because the metrics are new, none of them are available to cross-link in OpenTelemetry documentation: Semantic conventions for ASP.NET Core metrics. Currently, I'm placing commented-out cross-links into our content because it seems like after GA their content will be updated to include them. It will easy to activate the links later if I go ahead and place them now. Is that the right thing to do, or should I remove the commented-out cross-links to the OT doc?

  2. Resolved but needs review — I think I have the "Instrument Type" and "Unit (UCUM)" entries correct. 👀

  3. Resolved but needs review — I also worked with the rubber 🦆 to create the "Attribute" tables. 👀

  4. The pattern of the built-in metrics article matches the content that was placed in the "Blazor metrics" section for What's New content. However, the "Blazor tracing" content doesn't match and doesn't seem like it should go into the built-in metrics article. Do the tracing activities go into the article or not? If they do, then I'll need a little help organizing them for the article given that the coverage pattern doesn't match. For example, are the "Tags" in the What's New content for "Attributes" tables (the second tables)? If so, what's the first table? Is there a first table at all for each activity? You get the picture: I need to understand how to lay out the content.

WRT to the AppContext key for streaming responses, I only show .......

request.SetBrowserResponseStreamingEnabled(false);

... do I also need to show the following? ...

request.Options.Set(new HttpRequestOptionsKey<bool>("WebAssemblyEnableStreamingResponse"), false);

Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/call-web-api.md aspnetcore/blazor/call-web-api
aspnetcore/blazor/fundamentals/routing.md aspnetcore/blazor/fundamentals/routing
aspnetcore/blazor/performance/index.md aspnetcore/blazor/performance/index
aspnetcore/release-notes/aspnetcore-10.0.md aspnetcore/release-notes/aspnetcore-10.0

@guardrex
Copy link
Collaborator Author

@wadepickett @danroth27 ... 🦗🦗🦗 on the review request. I'll need to go ahead and merge this because there's guidance on here important to the release coverage. I'm 👂 for team feedback to place a patch PR later today.

@guardrex guardrex closed this Jun 10, 2025
@guardrex guardrex reopened this Jun 10, 2025
@guardrex guardrex merged commit 1a951bc into main Jun 10, 2025
4 checks passed
@guardrex guardrex deleted the guardrex/blazor-preview-5 branch June 10, 2025 20:22
@pavelsavara
Copy link
Member

thanks for doing this @guardrex, I will review it today and provide a feedback

@guardrex
Copy link
Collaborator Author

guardrex commented Jul 4, 2025

Thanks @pavelsavara ... and note that I'm updating the "Links" entries for Pre6 on the Pre6 PR, which will be ready for review on Monday. You can take a peek at those updates at ...

accfee7

I still need to make a final pass on the whole PR, so I'd hold off on any serious review of the Pre6 PR at this time.

@guardrex
Copy link
Collaborator Author

guardrex commented Jul 4, 2025

... and one more note ... I performed a general clean-up of the built-in metrics article after this PR went in at #35646. I think those are all just UI/layout updates. It looks better now ...

https://learn.microsoft.com/en-us/aspnet/core/log-mon/metrics/built-in?view=aspnetcore-9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants