-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[Pre5] Blazor What's New updates #35590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@wadepickett @danroth27 ... 🦗🦗🦗 on the review request. I'll need to go ahead and merge this because there's guidance on here important to the release coverage. I'm 👂 for team feedback to place a patch PR later today. |
thanks for doing this @guardrex, I will review it today and provide a feedback |
Thanks @pavelsavara ... and note that I'm updating the "Links" entries for Pre6 on the Pre6 PR, which will be ready for review on Monday. You can take a peek at those updates at ... I still need to make a final pass on the whole PR, so I'd hold off on any serious review of the Pre6 PR at this time. |
... and one more note ... I performed a general clean-up of the built-in metrics article after this PR went in at #35646. I think those are all just UI/layout updates. It looks better now ... https://learn.microsoft.com/en-us/aspnet/core/log-mon/metrics/built-in?view=aspnetcore-9.0 |
Addresses #35473
Fixes #35361
Addresses #34870
Fixes #34893
Fixes #35278
Ilona
You only need to see the Not Found parts.
Pavel
Note to self (PU PRs): dotnet/aspnetcore#61516 and dotnet/aspnetcore#61609
The metrics part of this is still incomplete ...
Check the DIFF to see my progress.
The rest of these questions refer to the coverage going into the main doc set's built-in metrics article at ...
https://learn.microsoft.com/en-us/aspnet/core/log-mon/metrics/built-in?view=aspnetcore-9.0
Because the metrics are new, none of them are available to cross-link in OpenTelemetry documentation: Semantic conventions for ASP.NET Core metrics. Currently, I'm placing commented-out cross-links into our content because it seems like after GA their content will be updated to include them. It will easy to activate the links later if I go ahead and place them now. Is that the right thing to do, or should I remove the commented-out cross-links to the OT doc?
Resolved but needs review — I think I have the "Instrument Type" and "Unit (UCUM)" entries correct. 👀
Resolved but needs review — I also worked with the rubber 🦆 to create the "Attribute" tables. 👀
The pattern of the built-in metrics article matches the content that was placed in the "Blazor metrics" section for What's New content. However, the "Blazor tracing" content doesn't match and doesn't seem like it should go into the built-in metrics article. Do the tracing activities go into the article or not? If they do, then I'll need a little help organizing them for the article given that the coverage pattern doesn't match. For example, are the "Tags" in the What's New content for "Attributes" tables (the second tables)? If so, what's the first table? Is there a first table at all for each activity? You get the picture: I need to understand how to lay out the content.
WRT to the AppContext key for streaming responses, I only show .......
... do I also need to show the following? ...
Internal previews