Update ClockHub.cs - Clarify the method's purpose #35706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear that this method is called by clients only
wadepickett
approved these changes
Jul 7, 2025
|
Thanks for adding some clarity to the method name. That is better. Much appreciated @MA-Maddin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended to make it clearer that the ClockHub's method is called (used) only by clients.
I was going through the "Host ASP.NET Core SignalR in background services" tutorial, but then wondered why
SendTimeToClients()isn't called anywhere.I first thought that this method is used by the server to send the current time to clients, but that's actually done by
_clockHubContext.Clients.All.ShowTime(DateTime.Now);Furthermore, it makes no sense that a(ny) client sends a time to all clients.
The tutorial would even work without this method, so
ClockHubcould be empty and everything runs as intended.