Reset _Settings to defaults rather than to null #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

yallie wants to merge 1 commit into dotnet:master from yallie:master

yallie commented Mar 13, 2025 •

edited

Loading

Setting _Settings to null is undesirable because the code never checks if _Settings is null before using it.

UPD. Sorry for the accidental whitespace changes!
It didn't change any visible formatting, but my IDE removed spaces at the end of the lines.

Please use the Hide whitespace changes button to review changes:

That's all, basically:


          Reset settings to defaults rather than to null, close dotnet#311, close

7e71a6b

dotnet#316.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet