Fix the target framework in the msi.proj now that net5.0 is unsupported by the sdk - #11284
Conversation
…ed by the sdk in arcade
| <PackageVersion>__PACKAGE_VERSION__</PackageVersion> | ||
| <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking> | ||
| <TargetFramework>net5.0</TargetFramework> | ||
| <TargetFramework>net7.0</TargetFramework> |
There was a problem hiding this comment.
@lewing should we make this a __TARGET_FRAMEWORK__ argument so that it can be passed in?
There was a problem hiding this comment.
$(TargetFramework) would be better since this is a template for a .csproj and you don't know up front under which build the project will be invoked. If it's a property, consumers can pass valid values and we can try to calculate a defualt.
|
Should we port this to main? |
Yep |
|
/backport to main |
|
looks like GitHub Actions aren't enabled in the arcade repo |
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/arcade/actions/runs/3388101051 |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/arcade/actions/runs/3430633107 |
See the failures in https://github.com/dotnet/emsdk/pull/238/checks?check_run_id=8896780677
cc @mmitche