Skip to content

Add option for LF line endings to OneLocBuild task - #7334

Merged
jonfortescue merged 1 commit into
dotnet:mainfrom
jonfortescue:AddLfLineEndingsOneLocBuild
May 3, 2021
Merged

Add option for LF line endings to OneLocBuild task#7334
jonfortescue merged 1 commit into
dotnet:mainfrom
jonfortescue:AddLfLineEndingsOneLocBuild

Conversation

@jonfortescue

Copy link
Copy Markdown
Contributor

OneLocBuild recently added the option to use LF line endings when checking in files. This is good bc most repos will want to use this, I believe. Nice!

To double check:

@jonfortescue
jonfortescue requested review from a user, ChadNedzlek and missymessa May 3, 2021 18:13
@jonfortescue jonfortescue self-assigned this May 3, 2021
Comment thread eng/common/templates/job/onelocbuild.yml

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about making true the default.

@jonfortescue

Copy link
Copy Markdown
Contributor Author

@riarenas CRLF seems to be wrong for most repos; that's what it is currently and it results in horrid whitespace changes and requires manual normalization to fix across all the repos I've worked with so far.

@ghost

ghost commented May 3, 2021

Copy link
Copy Markdown

That makes sense, and it makes it sound like like we really need this, and it's more of a real fix than a nice to have.

@ghost

ghost commented May 3, 2021

Copy link
Copy Markdown

CRLF seems to be wrong for most repos

Do you know of any repos where it's not wrong? If so we should have those on radar so that they don't get surprised by the new default.

@jonfortescue

Copy link
Copy Markdown
Contributor Author

@riarenas nope, there haven't been any so far lol.

@jonfortescue
jonfortescue merged commit 4bf515f into dotnet:main May 3, 2021
@jonfortescue
jonfortescue deleted the AddLfLineEndingsOneLocBuild branch May 3, 2021 20:07
@ChadNedzlek

Copy link
Copy Markdown
Contributor

Why can't we just use the .gitattributes in the repo to do the right thing? Why make this data duplicated there?

@jonfortescue

Copy link
Copy Markdown
Contributor Author

@ChadNedzlek The OneLocBuild task is not able to do that, unfortunately

@ChadNedzlek

ChadNedzlek commented May 3, 2021

Copy link
Copy Markdown
Contributor

It's a little weird that it's somehow bypassing that behavior already. shrugs I guess thems the breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants