Workaround for https://github.com/dotnet/arcade/issues/7371 - #7421
Merged
Conversation
…or failures if ADO fails for any reason, return 0 if we actually passed.
MattGal
marked this pull request as ready for review
May 20, 2021 22:28
agocke
approved these changes
May 20, 2021
agocke
reviewed
May 20, 2021
alexperovich
approved these changes
May 20, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have azure-pipelines reporter parse XML for failures if ADO fails for any reason, return 0 if we actually passed until the Helix Client does this itself.
To double check:
Since this is a weird error-case from an API we don't have a way to mock, I created this run where every worker in the Azure-DevOps reporter crashes. Note in that run the non-XUnit results were expected to and did fail because I didn't check for them; this is just to mitigate the main stream scenario of XUnit results. If we need to keep this workaround for a longer time can implement that.
Helix Log