Skip to content

Workaround for https://github.com/dotnet/arcade/issues/7371 - #7421

Merged
MattGal merged 2 commits into
dotnet:mainfrom
MattGal:arcade-7371
May 21, 2021
Merged

Workaround for https://github.com/dotnet/arcade/issues/7371#7421
MattGal merged 2 commits into
dotnet:mainfrom
MattGal:arcade-7371

Conversation

@MattGal

@MattGal MattGal commented May 20, 2021

Copy link
Copy Markdown
Member

Have azure-pipelines reporter parse XML for failures if ADO fails for any reason, return 0 if we actually passed until the Helix Client does this itself.

To double check:

Since this is a weird error-case from an API we don't have a way to mock, I created this run where every worker in the Azure-DevOps reporter crashes. Note in that run the non-XUnit results were expected to and did fail because I didn't check for them; this is just to mitigate the main stream scenario of XUnit results. If we need to keep this workaround for a longer time can implement that.

Helix Log

Reporting has failed.  Running mitigation for https://github.com/dotnet/arcade/issues/7371
Searching 'C:\h\w\A8DD094C\w\B173094F\e' for test results files
Found results file C:\h\w\A8DD094C\w\B173094F\e\testResults.xml 
Searching 'C:\h\w\A8DD094C\w\B173094F\uploads' for test results files
Reporter script has failed, but we were able to find XUnit test results with no failures.

…or failures if ADO fails for any reason, return 0 if we actually passed.
@MattGal
MattGal marked this pull request as ready for review May 20, 2021 22:28

@agocke agocke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/reporter/run.py Outdated
Comment thread src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/reporter/run.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants