Change Object mode for package testing & remove older frameworks & rids - #7510
Conversation
Anipik
commented
Jun 10, 2021
- use nuget content model for package object similar to package validation.
- remove out of support frameworks.
- remove rids metadata as we no longer need.
- modify tests
…ll supported frameworks and add min dotnet version for packages contatining netstandard config
|
Cool. You are missing the props file which defines the current set of tfms:
|
shouldnt this be set in the runtime repo ? so that when the tfms go out of support we can just change the property in the runtime repo. |
Projects that live in arcade are meant to be consumed by multiple repositories. Moving the current set of supported TFMs into a props file a) makes it easier for multiple repositories to use the package and b) allows consumers to mutate that list. Imagine a repository like dotnet/runtime that versions to the next version of .NETCoreApp and wants to do that independently of the current set of exposed supported TFMs in this package. In example dotnet/runtime versions from .NET 6 to .NET 7 and can add this code block temporarily to avoid a change in the package itself: At a later point these changes will then flow back into this package to keep the defined TFMs consistent with the .NET support policy. |
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <SupportedTestFramework Include="netcoreapp3.1;net5.0;net6.0;net461;net462;net471;net472;net48;netstandard2.0;netstandard2.1" /> |
There was a problem hiding this comment.
SupportedTargetFramework is currently set by the sdk and it contains all the frameworks so i defined it as SupportedTestFramework
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <SupportedTestFramework Include="netcoreapp3.1;net5.0;net6.0;net461;net462;net471;net472;net48;netstandard2.0;netstandard2.1" /> |
There was a problem hiding this comment.
I believe you are missing test coverage in the test assembly as when I tried to add net6.0 last time, the NuGet Parse mechanism blew up. Can you please add a test that passes these items in?
There was a problem hiding this comment.
the tests contains
and tested with runtime repo as well.