Skip to content

Support ignoremvidmismatch option in ibcmerge - #7599

Merged
genlu merged 2 commits into
dotnet:mainfrom
genlu:ibcmergeIgnore
Jul 8, 2021
Merged

Support ignoremvidmismatch option in ibcmerge#7599
genlu merged 2 commits into
dotnet:mainfrom
genlu:ibcmergeIgnore

Conversation

@genlu

@genlu genlu commented Jul 7, 2021

Copy link
Copy Markdown
Member

Address the ibcmerge mismatch MVID error encountered in Roslyn build
dotnet/roslyn#53197

The new switch is added in https://devdiv.visualstudio.com/DevDiv/_git/DotNet-IbcMerge/pullrequest/335636

FYI @JoeRobich

@genlu
genlu requested review from davidwrighton and tmat July 7, 2021 18:23
Comment thread src/Microsoft.DotNet.Arcade.Sdk/tools/OptimizationData.targets Outdated

@davidwrighton davidwrighton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@genlu

genlu commented Jul 7, 2021

Copy link
Copy Markdown
Member Author

@davidwrighton @tmat Is there a way to validate this change before hitting merge?

@genlu
genlu merged commit 189395d into dotnet:main Jul 8, 2021
@genlu
genlu deleted the ibcmergeIgnore branch July 8, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants