Update workload pack tasks

[joeloff]

• Extract ProductLanguage into JSON manifest - these will be needed in the CLI to detect related products when dealing with upgrades for manifest MSIs
• Remove icon file from generated csproj
• Only add pack dependencies if they exist

[joeloff]

@pjcollins hold off on reviewing, there's another fix that needs to go into this to extract more information we need in the CLI

[joeloff]

Here's a sample of what the new metadata will look like. We're extracting the Upgrade table (if present). Otherwise, we need to make make DB calls to extract the information from the MSI at install time and that would add a lot more complexity to the CLI logic. @dsplaisted as an FYI

So turning this

into

"RelatedProducts": [
        {
            "UpgradeCode": "{08747630-CB79-3B55-860C-EBEE4EE0C769}",
            "VersionMin": null,
            "VersionMax": {
                "Major": 1,
                "Minor": 2,
                "Build": 2,
                "Revision": -1,
                "MajorRevision": -1,
                "MinorRevision": -1
            },
            "Language": "1033",
            "Attributes": 1
        },
        {
            "UpgradeCode": "{08747630-CB79-3B55-860C-EBEE4EE0C769}",
            "VersionMin": {
                "Major": 1,
                "Minor": 2,
                "Build": 2,
                "Revision": -1,
                "MajorRevision": -1,
                "MinorRevision": -1
            },
            "VersionMax": null,
            "Language": "1033",
            "Attributes": 2
        }
    ]

[chcosta]

You might have to define an empty "PackageIcon" property so that Arcade doesn't provide defaults and then adds the item group for you.

[joeloff]

I ran under Arcade SDK in dotnet/installer and it seems to work, but I will condition the target

[chcosta]

If it works, that's great. I wouldn't think the target would need a condition. I just thought you would have to undefine packageicon in your project to prevent this from executing because Arcade just default defines it here. Perhaps I'm missing something though.

[pjcollins]

The latest icon related changes appear to be working for me.