Skip to content

Update interactive-mode example of adding an Arcade subscription - #7622

Merged
1 commit merged into
dotnet:mainfrom
dagood:update-example-sub
Jul 19, 2021
Merged

Update interactive-mode example of adding an Arcade subscription#7622
1 commit merged into
dotnet:mainfrom
dagood:update-example-sub

Conversation

@dagood

@dagood dagood commented Jul 14, 2021

Copy link
Copy Markdown
Member

To double check:


Updating Documentation/DependencyFlowOnboarding.md after going through it:

  • With the standard Merge Policy, the Maestro++ PR check said Maestro auto-merge - Not implemented merge policy 'standard'. Changing to Standard (like other subscriptions I see) then closing the PR and triggering a new one seems to have fixed that.

  • I noticed Pull Request Failure Notification Tags: '' now shows up in interactive mode, but isn't in the doc. It's fairly obvious what it does, and I left it blank, but I figured the example might as well include it.

The non-interactive example appears to do something different--not sure if it's more correct or less correct than interactive. 😄 I'd personally consider removing one of the options to simplify the doc (and its maintenance).

/cc @riarenas @MattGal

@dagood dagood self-assigned this Jul 14, 2021

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Davis!

@MattGal MattGal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ghost
ghost merged commit 7cbe70f into dotnet:main Jul 19, 2021
@dagood
dagood deleted the update-example-sub branch July 26, 2021 03:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants