Skip to content

Handle the lack of a ScmRepositoryUrl when batch updating SourceRoot items. - #7852

Merged
MattGal merged 1 commit into
dotnet:mainfrom
MattGal:SourceLinkUrl-tweaks
Sep 8, 2021
Merged

Handle the lack of a ScmRepositoryUrl when batch updating SourceRoot items.#7852
MattGal merged 1 commit into
dotnet:mainfrom
MattGal:SourceLinkUrl-tweaks

Conversation

@MattGal

@MattGal MattGal commented Sep 8, 2021

Copy link
Copy Markdown
Member

Addresses #7850 . Big thanks to @rainersigwald for the MSBuild guidance.

To double check:

@rainersigwald rainersigwald left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I also collaborated with Matt offline so 🧂.

@MattGal
MattGal enabled auto-merge (squash) September 8, 2021 16:40
@michellemcdaniel

Copy link
Copy Markdown
Contributor

Thanks for the quick fix Matt!

@MattGal
MattGal merged commit 89db4b3 into dotnet:main Sep 8, 2021
MattGal added a commit to MattGal/arcade that referenced this pull request Sep 8, 2021
Address dotnet#7850 - handle the lack of a ScmRepositoryUrl when batch updating (dotnet#7852)
MattGal added a commit that referenced this pull request Sep 8, 2021
Address #7850 - handle the lack of a ScmRepositoryUrl when batch updating (#7852)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants