Skip to content

Fix path bug in DownloadFromResultsContainer.targets - #7961

Merged
safern merged 1 commit into
dotnet:mainfrom
kunalspathak:download-helix-results
Sep 27, 2021
Merged

Fix path bug in DownloadFromResultsContainer.targets#7961
safern merged 1 commit into
dotnet:mainfrom
kunalspathak:download-helix-results

Conversation

@kunalspathak

Copy link
Copy Markdown
Contributor

https://github.com/dotnet/arcade/pull/6179/files fixed an issue with downloading helix files, but it was still reproing with following errors (reference dotnet/runtime#59489 (comment)).

D:\workspace\_work\1\s\.packages\microsoft.dotnet.helix.sdk\7.0.0-beta.21463.4\tools\download-results\DownloadFromResultsContainer.targets(24,5): error MSB4018: The "DownloadFromResultsContainer" task failed unexpectedly. [D:\workspace\_work\1\s\src\coreclr\scripts\exploratory.proj]
D:\workspace\_work\1\s\.packages\microsoft.dotnet.helix.sdk\7.0.0-beta.21463.4\tools\download-results\DownloadFromResultsContainer.targets(24,5): error MSB4018: System.IO.IOException: The filename, directory name, or volume label syntax is incorrect. : 'D:\workspace\_work\1\s\src\coreclr\scripts\$([MSBuild]::NormalizeDirectory('$(BUILD_SOURCESDIRECTORY)', 'artifacts', helixresults'))\9e889cb3-8222-4f97-b8c4-c95ff9d8fa88' [D:\workspace\_work\1\s\src\coreclr\scripts\exploratory.proj]
D:\workspace\_work\1\s\.packages\microsoft.dotnet.helix.sdk\7.0.0-beta.21463.4\tools\download-results\DownloadFromResultsContainer.targets(24,5): error MSB4018:    at System.IO.FileSystem.CreateDirectory(String fullPath, Byte[] securityDescriptor) [D:\workspace\_work\1\s\src\coreclr\scripts\exploratory.proj]
D:\workspace\_work\1\s\.packages\microsoft.dotnet.helix.sdk\7.0.0-beta.21463.4\tools\download-results\DownloadFromResultsContainer.targets(24,5): error MSB4018:    at System.IO.Directory.CreateDirectory(String path) [D:\workspace\_work\1\s\src\coreclr\scripts\exploratory.proj]
D:\workspace\_work\1\s\.packages\microsoft.dotnet.helix.sdk\7.0.0-beta.21463.4\tools\download-results\DownloadFromResultsContainer.targets(24,5): error MSB4018:    at Microsoft.DotNet.Helix.Sdk.DownloadFromResultsContainer.ExecuteCore() in /_/src/Microsoft.DotNet.Helix/Sdk/DownloadFromResultsContainer.cs:line 66 [D:\workspace\_work\1\s\src\coreclr\scripts\exploratory.proj]
D:\workspace\_work\1\s\.packages\microsoft.dotnet.helix.sdk\7.0.0-beta.21463.4\tools\download-results\DownloadFromResultsContainer.targets(24,5): error MSB4018:    at Microsoft.DotNet.Helix.Sdk.DownloadFromResultsContainer.Execute() in /_/src/Microsoft.DotNet.Helix/Sdk/DownloadFromResultsContainer.cs:line 58 [D:\workspace\_work\1\s\src\coreclr\scripts\exploratory.proj]
D:\workspace\_work\1\s\.packages\microsoft.dotnet.helix.sdk\7.0.0-beta.21463.4\tools\download-results\DownloadFromResultsContainer.targets(24,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [D:\workspace\_work\1\s\src\coreclr\scripts\exploratory.proj]
D:\workspace\_work\1\s\.packages\microsoft.dotnet.helix.sdk\7.0.0-beta.21463.4\tools\download-results\DownloadFromResultsContainer.targets(24,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [D:\workspace\_work\1\s\src\coreclr\scripts\exploratory.proj]
##[error].packages\microsoft.dotnet.helix.sdk\7.0.0-beta.21463.4\tools\download-results\DownloadFromResultsContainer.targets(24,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "DownloadFromResultsContainer" task failed unexpectedly.
System.IO.IOException: The filename, directory name, or volume label syntax is incorrect. : 'D:\workspace\_work\1\s\src\coreclr\scripts\$([MSBuild]::NormalizeDirectory('$(BUILD_SOURCESDIRECTORY)', 'artifacts', helixresults'))\9e889cb3-8222-4f97-b8c4-c95ff9d8fa88'
   at System.IO.FileSystem.CreateDirectory(String fullPath, Byte[] securityDescriptor)
   at System.IO.Directory.CreateDirectory(String path)
   at Microsoft.DotNet.Helix.Sdk.DownloadFromResultsContainer.ExecuteCore() in /_/src/Microsoft.DotNet.Helix/Sdk/DownloadFromResultsContainer.cs:line 66
   at Microsoft.DotNet.Helix.Sdk.DownloadFromResultsContainer.Execute() in /_/src/Microsoft.DotNet.Helix/Sdk/DownloadFromResultsContainer.cs:line 58
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)


```

Looks like there was a surrounding `'` that should not be there.

@kunalspathak

Copy link
Copy Markdown
Contributor Author

@safern

@kunalspathak

Copy link
Copy Markdown
Contributor Author

@safern - can this be merged or we need more approvals?

@safern
safern merged commit 7363d2e into dotnet:main Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants