Skip to content

Pass directory path from call-site - #7984

Merged
jkoritzinsky merged 1 commit into
dotnet:mainfrom
am11:feature/configs
Oct 1, 2021
Merged

Pass directory path from call-site#7984
jkoritzinsky merged 1 commit into
dotnet:mainfrom
am11:feature/configs

Conversation

@am11

@am11 am11 commented Oct 1, 2021

Copy link
Copy Markdown
Member

When init-compiler is sourced (as opposed to eval'd), the script was
throwing an error: pipeline-logging-functions.sh: No such file or directory.

Reflecting changes from dotnet/runtime#59858.

@am11

am11 commented Oct 1, 2021

Copy link
Copy Markdown
Member Author

cc @jkoritzinsky, @janvorli

Comment thread eng/common/native/init-compiler.sh Outdated
@am11
am11 force-pushed the feature/configs branch from 66d362b to 4cb9fbb Compare October 1, 2021 12:55
@jkoritzinsky

Copy link
Copy Markdown
Member

We might need to make changes in dotnet/diagnostics as well to react to this. Can we solve this problem differently (without making a breaking change for the script)?

@am11

am11 commented Oct 1, 2021

Copy link
Copy Markdown
Member Author

@jkoritzinsky, dotnet/diagnostics does not use anything from shared location which we have just started to use. It doesn't even use the latest of dotnet/coreclr (it is super old and stale version..).

@am11

am11 commented Oct 1, 2021

Copy link
Copy Markdown
Member Author

@am11

am11 commented Oct 1, 2021

Copy link
Copy Markdown
Member Author

I knew this off-hand, because I already have a WIP branch to close the gap between diagnostics config: dotnet/diagnostics@main...am11:feature/build-infra rejuvenation in progress.. 😉

We may want to share more scripts via eng/common/native between runtime and diagnostics. That's something I will follow up with you, @hoyosjs and @janvorli once I have diagnostics PR up (but it is unrelated to the changes here which only fix a warning in runtime).

@jkoritzinsky
jkoritzinsky merged commit b3364cf into dotnet:main Oct 1, 2021
@am11
am11 deleted the feature/configs branch October 1, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants