Pass directory path from call-site - #7984
Conversation
|
We might need to make changes in dotnet/diagnostics as well to react to this. Can we solve this problem differently (without making a breaking change for the script)? |
|
@jkoritzinsky, dotnet/diagnostics does not use anything from shared location which we have just started to use. It doesn't even use the latest of dotnet/coreclr (it is super old and stale version..). |
|
I knew this off-hand, because I already have a WIP branch to close the gap between diagnostics config: dotnet/diagnostics@main...am11:feature/build-infra rejuvenation in progress.. 😉 We may want to share more scripts via eng/common/native between runtime and diagnostics. That's something I will follow up with you, @hoyosjs and @janvorli once I have diagnostics PR up (but it is unrelated to the changes here which only fix a warning in runtime). |
When init-compiler is sourced (as opposed to
eval'd), the script wasthrowing an error:
pipeline-logging-functions.sh: No such file or directory.Reflecting changes from dotnet/runtime#59858.