Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflows to use fork of create-pull-request #8122

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Update workflows to use fork of create-pull-request #8122

merged 1 commit into from
Mar 18, 2025

Conversation

joperezr
Copy link
Member

Description

FYI: @eerhardt

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
  • Does the change require an update in our Aspire docs?
    • No

@Copilot Copilot bot review requested due to automatic review settings March 17, 2025 20:37
@github-actions github-actions bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Mar 17, 2025
@joperezr joperezr requested review from eerhardt and richlander and removed request for Copilot March 17, 2025 20:37
@radical
Copy link
Member

radical commented Mar 17, 2025

cc @danmoseley
Also, related: #8122

eerhardt
eerhardt approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this still works, LGTM

@joperezr
Copy link
Member Author

Assuming this still works, LGTM

Yeah, tested on my fork and it works as expected, this is also what aspnetcore uses https://github.com/dotnet/aspnetcore/blob/18b3b4ac8dfc4498edc6bf26c7bde9a35ef840f8/.github/workflows/update-jquery-validate.yml#L41-L54

@joperezr joperezr merged commit 0572eea into main Mar 18, 2025
163 checks passed
@joperezr joperezr deleted the UpdateWorkflows branch March 18, 2025 17:06
@danmoseley
Copy link
Member

Looks like some other repos need this too
https://grep.app/search?f.lang=YAML&f.repo.pattern=dotnet%2F&q=peter-evans%2Fcreate-pull-request

@danmoseley
Copy link
Member

I'll make PR's for them.

@danmoseley
Copy link
Member

put up PR's for ours anyway.

@gewarren gewarren mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@richlander richlander Awaiting requested review from richlander

Assignees
No one assigned
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joperezr @radical @danmoseley @eerhardt