-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests for resourceready #8148
tests for resourceready #8148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds tests verifying the resource health checks behave correctly under different ResourceReadyEvent conditions.
- Adds test to verify resources report an unhealthy status while a ResourceReadyEvent is running.
- Adds test to verify resources become healthy once the ResourceReadyEvent completes or when it is not present.
- Adds test to validate resources remain unhealthy when the ResourceReadyEvent fails.
https://github.com/dotnet/aspire/pull/7163/files#diff-8615d91b88608bf1e83f12f2ca649821b8594770f6408c126b824edc38096ad7R222 is a test of some of this but I wanted to unfold the various scenarios here with other similar tests. |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Closes #7364
Add tests for this which seems to have already been fixed by David in https://github.com/dotnet/aspire/pull/7163/files#diff-277b90393b291fcd3931cae92e7467ad513f793a3e5033bb85b1028b70c30a90
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):