[CI] Combine Templates, and Integrations test workflows #8202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-engineering-systems
joperezr
reviewed
Mar 20, 2025
| @@ -1,5 +1,4 @@ | |||
| # Executes the integration tests on all platforms | |||
| name: Integration | |||
| name: Tests | |||
There was a problem hiding this comment.
Minor nit, but we should also rename this file as it is no longer just integration tests. Also, any reason why we can't combine this with run-tests.yml?
There was a problem hiding this comment.
run-tests.yml is the workflow being re-used for the various test/os combinations that we have here.
Since both the workflows reuse `run-tests.yml`, we can combine these two into one workflow. This allows having a single place to check the results, and final counts for the tests.
…es since we are collecting the list of tests separately for each OS
radical
force-pushed
the
combine-workflows
branch
from
73d93b2 to
bdb6a01
Compare
|
Before this can be merged the existing |
RussKie
approved these changes
Mar 20, 2025
This reverts commit c8132fb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CI] Combine Templates, and Integrations test workflows
Since both the workflows reuse
run-tests.yml, we can combine these twointo one workflow. This allows having a single place to check the
results, and final counts for the tests.
Disable EndToEnd, and Playground tests for windows in the project files since we are collecting the list of tests separately for each OS
unrelated: Correctly rename Aspire.Templates.Tests/WorkloadTestsBase.cs to TemplateTestsBase.cs