Skip to content

Show/hide hidden resources on dashboard #9180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

adamint
Copy link
Member

@adamint adamint commented May 8, 2025

Description

Allows showing/hiding hidden resources on the dashboard. See below gif

Grabacion.de.pantalla.2025-05-08.a.la.s.5.40.45.p.m.mov

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK
Copy link
Member

JamesNK commented May 9, 2025

I want to test this myself before approving and I'm not sure how to get a hidden resource. TestShop doesn't have any.

Add some hidden resources to stress playground. Folks (i.e. me) can test it there.

Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, agree with James' feedback on clarity. But good to get this in for 9.3

@adamint
Copy link
Member Author

adamint commented May 9, 2025

I want to test this myself before approving and I'm not sure how to get a hidden resource. TestShop doesn't have any.

Add some hidden resources to stress playground. Folks (i.e. me) can test it there.

The stress app already contains one hidden parameter resource (shown in the video). I added an additional hidden container. See below:
image

@adamint
Copy link
Member Author

adamint commented May 9, 2025

I'll wait to merge until James' approval.

@davidfowl
Copy link
Member

Can we get this resolved asap?

@JamesNK
Copy link
Member

JamesNK commented May 10, 2025

There is an issue with choosing to hide hidden resources while looking at the console logs for a hidden resource:
hidden-resources

I don't know why it chose stress-apiservice to change to when hiddenResouce was no longer available but that's wrong.

I would expect that hiding the hidden resource would change the selected resource to change to "None" and the console log content to become empty. This is the same behavior as navigating to /consolelogs/resource/hiddenContainer with hidden resources hidden.

@JamesNK
Copy link
Member

JamesNK commented May 10, 2025

If you select stress-apiservice in the console logs page and then choose to show hidden resources then it switches to hiddenContainer:

hidden-resource-show

Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments for bugs

@dotnet-policy-service dotnet-policy-service bot added the needs-author-action An issue or pull request that requires more info or actions from the author. label May 10, 2025
@adamint adamint requested a review from JamesNK May 12, 2025 20:44
@JamesNK
Copy link
Member

JamesNK commented May 12, 2025

I still see issues around hiding and unhiding hidden resources in the console logs page. stress-apiservice and stress-telemetryservice switch being selected in the resource drop down for some reason.

show-hidden-resources

@dotnet-policy-service dotnet-policy-service bot removed the needs-author-action An issue or pull request that requires more info or actions from the author. label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants