Fix CLI to cleanup invalid project names #9366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-integrations
There was a problem hiding this comment.
Pull Request Overview
This PR improves the CLI’s handling of invalid project names by sanitizing them automatically and notifying the user with warnings. Key changes include the addition of new tests, the introduction of a DisplayWarning message in the interaction layer, and modifications to both the project name retrieval and validation logic in NewCommand.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Cli.Tests/Utils/ProjectNameValidatorTests.cs | Added unit tests to verify project name validation and sanitization behavior. |
| tests/Aspire.Cli.Tests/Commands/NewCommandTests.cs | Added end-to-end tests to ensure invalid project names are correctly sanitized on the command line. |
| src/Aspire.Cli/Interaction/InteractionService.cs | Introduced DisplayWarning functionality to present user-friendly warnings. |
| src/Aspire.Cli/Interaction/IInteractionService.cs | Updated interface to include a DisplayWarning method. |
| src/Aspire.Cli/Commands/NewCommand.cs | Refactored project name handling to sanitize invalid names and display warnings; updated ProjectNameValidator regex and sanitization logic. |
danmoseley
commented
May 16, 2025
| @@ -641,6 +641,58 @@ public async Task NewCommand_WhenCertificateServiceThrows_ReturnsNonZeroExitCode | |||
| Assert.Equal(ExitCodeConstants.FailedToTrustCertificates, exitCode); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task NewCommand_SanitizesInvalidProjectName_WhenProvidedOnCommandLine() | |||
There was a problem hiding this comment.
really don't know if there is a better way to write this. copilot did it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vibe coded :)
Fixes #9290
Fixes #9327
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate