[release/6.0-preview6] Update dependencies from dotnet/runtime dotnet/efcore - #33571
Conversation
…615.13 Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design From Version 6.0.0-preview.6.21315.1 -> To Version 6.0.0-preview.6.21315.13
…0615.7 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.AspNetCore.Internal.Transport , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Configuration.Ini , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.IO.Pipelines , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols From Version 6.0.0-preview.6.21314.2 -> To Version 6.0.0-preview.6.21315.7
…616.3 Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design From Version 6.0.0-preview.6.21315.1 -> To Version 6.0.0-preview.6.21316.3
|
Needs a reaction to dotnet/runtime#54147. I'm working on it… |
- remove newly-unnecessary package references - do not expect affected assemblies in _our_ targeting packs
|
I doubt the commit I added will be enough. Expect we need |
|
@dotnet/aspnet-build please keep an eye on this because I'm not sure we're done reacting. I need to run an errand… |
|
Getting Helix failures (only Helix) in
And similar tests |
|
@dougbu is it expected that we now need to add |
|
We'd done some work to remove those assemblies from the shared fx / targeting pack: aspnet/Announcements#456. @ericstj are they supposed to be back? |
|
/cc @ViktorHofer why are we getting more assemblies in Microsoft.AspNetCore.App.Runtime.*❔ |
|
Hmm, we exclude Microsoft.Win32.SystemEvents, System.Drawing.Common, System.Security.Permissions, and System.Windows.Extensions from the targeting packs (along w/ System.Security.Cryptography.Pkcs). Maybe we need something similar for the shared Fx❔ |
|
The targeting pack tests are failing the same way, also only on Helix |
|
We exposed the following reference assemblies in the Microsoft.NETCore.App.Ref targeting pack:
All of these shouldn't be present in your targeting/runtime pack as Microsoft.NETCore.App.* exposes them now. |
I think we're making a bad situation worse if we remove 6.0 packages that may otherwise need to be serviced in the future. Switching to 5.0 versions doesn't help much because it will be a manual process to update them going forward. I'd much rather have 6.0 packages, perhaps ones that no longer contain .NET Core assemblies. |
Servicing is unlikely. The packages have reference assemblies and full facades for .NETFramework. On .NETCore these were all part of the framework already so we already service them in the shared framework. The packages were just giving you reference assemblies. |
This was present in the previous release and shouldn't be removed since this is part of the public contract of the netstandard2.0 build of DataProtection.
|
Looks like this one might be a winner 🤞 |
dougbu
left a comment
There was a problem hiding this comment.
Suspect we need a @(SuppressBaselineReference) item or two for Microsoft.Win32.Registry references we're removing
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
|
@ericstj I agree we have a few dependencies on old versions of dead-ended packages. Was calling this out as potentially problematic, not to imply it's a new thing. In any case,
I thought the packages also contained |
|
Oops, I'll fix the current failures up in a minute. Requires a change to eng/Dependencies.props. |
…aProtection.csproj
- add excluded System.Security.Permissions references - stop auto-updating dead-ended packages - switch to 5.0.0 version of Microsoft.Win32.Registry - switch to 5.0.0 version of System.Security.Principal.Windows
|
My assumption about the precedence of ExcludeAssets being transitive was wrong. Since the dependencies of SSP are transitive it lets the non-excluded references win over those marked with exclude. To workaround we need to add all of them. |
Sure, but these are typically ignored on .NETCore since the shared-framework should have a higher version. There aren't going to be any in-support .NETCore frameworks that use that asset eventually, so it's a point in time problem that we care about servicing the package (until |
| <LatestPackageReference Include="Microsoft.Win32.SystemEvents" /> | ||
| <LatestPackageReference Include="System.Drawing.Common" /> | ||
| <LatestPackageReference Include="System.Security.Permissions" /> | ||
| <LatestPackageReference Include="System.Windows.Extensions" /> |
There was a problem hiding this comment.
Need the three of these that aren't already in eng/Version.Details.xml to either use 5.0.0 versions (and move out of the automated section of eng/Versions.props) or be included in eng/Version.Details.xml.
There was a problem hiding this comment.
These all still build live, so they can be included in the main section. These should all be temporary until dotnet/runtime#54341 is addressed. IMHO it's worth carrying this package (System.Security.AccessControl) for one more release to make the type move. I'd like to hear @ViktorHofer's thoughts.
|
Hurray❕ Many thanks to @ericstj and everyone else involved in this long slog. |
[main] Update dependencies from dotnet/runtime dotnet/efcore - React to dotnet/runtime#54147 - remove newly-unnecessary package references - do not expect affected assemblies in _our_ targeting packs - Add baseline suppression - !fixup! Suppress correct reference - Manually align w/ #33571 - add excluded System.Security.Permissions references - stop auto-updating dead-ended packages - switch to 5.0.0 version of Microsoft.Win32.Registry - switch to 5.0.0 version of System.Security.Principal.Windows - Suppress all of System.Security.Permissions dependency closure - cherry-picked from #33571 - Add missing dependencies - cherry-picked from #33571
This pull request updates the following dependencies
From https://github.com/dotnet/efcore
From https://github.com/dotnet/runtime