Always run inline for socket callbacks - #44465
Merged
Merged
Conversation
davidfowl
commented
Oct 11, 2022
Member
- .NET 8 removed the windows native threadpool fallback for socket IO completions. Remove the checks for flags that no longer exist.
- .NET 8 removed the windows native threadpool fallback for socket IO completions. Remove the checks for flags that no longer exist.
davidfowl
requested review from
BrennanConroy,
JamesNK,
Tratcher and
halter73
as code owners
October 11, 2022 06:13
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Oct 11, 2022
Closed
BrennanConroy
approved these changes
Oct 11, 2022
BrennanConroy
left a comment
Member
There was a problem hiding this comment.
Removal for reference: dotnet/runtime#71719
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.