-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[9.0] Make duplicate deb/rpm packages so we can sign them with the new PMC key #63249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/9.0
Are you sure you want to change the base?
Conversation
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/16951661469 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR creates duplicate DEB and RPM package files to support signing with a new PMC (Package Manager Client) key for upcoming Linux distributions like Debian 13 and SLES vNext, while maintaining existing keys for current feeds.
- Introduces new build properties and targets for creating "newkey" variants of installer packages
- Adds copy operations to generate duplicate package files with "-newkey" suffixes
- Maintains existing build processes while extending them to support dual signing requirements
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/Installers/Rpm/Directory.Build.props | Adds NewKeyVersionSuffix property for RPM packages |
src/Installers/Rpm/Directory.Build.targets | Implements copy operation to create newkey RPM variants |
src/Installers/Rpm/TargetingPack/Rpm.TargetingPack.rpmproj | Defines NewKeyBaseName and NewKeyExtension properties |
src/Installers/Rpm/Runtime/Rpm.Runtime.rpmproj | Defines NewKeyBaseName and NewKeyExtension properties |
src/Installers/Debian/Directory.Build.targets | Implements copy operation to create newkey DEB variants |
src/Installers/Debian/TargetingPack/Debian.TargetingPack.debproj | Defines NewKeyTargetFileName property |
src/Installers/Debian/Runtime/Debian.Runtime.debproj | Defines NewKeyTargetFileName property |
@@ -60,5 +60,6 @@ | |||
</PropertyGroup> | |||
|
|||
<Copy SourceFiles="$(IntermediateOutputPath)out/$(BuildScriptOutputFileName)" DestinationFiles="$(TargetPath)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy operation lacks consistency with the RPM implementation. Consider adding a message task similar to line 114 in the RPM Directory.Build.targets to provide feedback about the copy operation.
<Copy SourceFiles="$(IntermediateOutputPath)out/$(BuildScriptOutputFileName)" DestinationFiles="$(TargetPath)" /> | |
<Copy SourceFiles="$(IntermediateOutputPath)out/$(BuildScriptOutputFileName)" DestinationFiles="$(TargetPath)" /> | |
<Message Text="Copying $(IntermediateOutputPath)out/$(BuildScriptOutputFileName) to $(OutputPath)$(NewKeyTargetFileName)" Importance="high" /> |
Copilot uses AI. Check for mistakes.
Hi @@jkoritzinsky. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
Contributes to dotnet/arcade#16047
Make duplicate deb/rpm packages so we can sign them with the new PMC key
Description
PMC has added a new signing key for packages published to repositories for new Linux distributions they will add support for, such as Debian 13 and SLES vNext. Packages pushed to these feeds must be signed with the new key. Existing feeds will maintain the same keys. The .NET signing infrastructure requires us to have separate copies of the package files to have them signed with different keys. This PR introduces separate copies of the DEB and RPM installers to be signed with the new signing keys.
Contributes to dotnet/arcade#16047
Customer Impact
Without this change, we can't ship
.deb
installers for Debian 13. With this change, we can.Regression?
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?