Skip to content

Conversation

oroztocil
Copy link
Member

@oroztocil oroztocil commented Aug 23, 2025

This test has not failed in the last 30 days (https://dev.azure.com/dnceng-public/public/_test/analytics?definitionId=84&contextType=build).

When running all tests from the test class locally in a loop, 300/300 runs succeeded.

Fixes #60472

…esCancellationTokenThatSignalsWhenRevalidationLoopIsBeingDiscarded
@github-actions github-actions bot added the area-blazor Includes: Blazor, Razor Components label Aug 23, 2025
@oroztocil oroztocil changed the title Unquarantine RevalidatingServerAuthenticationStateProviderTest.Suppli… Unquarantine RevalidatingServerAuthenticationStateProviderTest.SuppliesCancellationTokenThatSignalsWhenRevalidationLoopIsBeingDiscarded Aug 23, 2025
@oroztocil oroztocil marked this pull request as ready for review August 25, 2025 10:18
@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 10:18
@oroztocil oroztocil requested a review from a team as a code owner August 25, 2025 10:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR unquarantines a previously flaky test by removing the [QuarantinedTest] attribute, indicating the test has been stable for 30 days and is now safe to run in the regular test suite.

  • Removes quarantine attribute from a specific test method
  • Re-enables the test in the regular CI pipeline

@ilonatommy ilonatommy added this to the 10.0-rc2 milestone Aug 25, 2025
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to pinpoint the change that could have fixed it?

@oroztocil
Copy link
Member Author

Are we able to pinpoint the change that could have fixed it?

Nope. Based on a brief investigation, I could not find any change that we could point to as the reason that the test has been fixed (made deterministic). None of the directly related sources have changed since the test got quarantined.

@oroztocil oroztocil merged commit cd1d256 into main Aug 25, 2025
30 checks passed
@oroztocil oroztocil deleted the oroztocil/60472-unquarantine-RevalidatingServerAuthenticationStateProviderTest branch August 25, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
2 participants