Update all projects to netstandard 2.0 minimum #2761
Conversation
| // Since there are 120 tests here (8 * 15), setting low values for the warmupCount and targetCount | ||
| [SimpleJob(-1, 3, 5)] | ||
| [MemoryDiagnoser] | ||
| public class JsonParserPerf |
There was a problem hiding this comment.
I believe most of the relevant benchmarks from here got moved to dotnet/performance.
If we missed some interesting tests, we can always look back at the history and grab some :)
cc @jozkee
There was a problem hiding this comment.
Yup. Looks like it got moved to https://github.com/dotnet/performance/blob/master/src/benchmarks/micro/corefx/System.Text.Json/Utf8JsonReader/Perf.Reader.cs.
|
|
||
| namespace System.Text.JsonLab.Tests | ||
| { | ||
| public class ReadFromPipeTests : IDisposable |
There was a problem hiding this comment.
FYI @tdykstra
This is roughly what reading JSON from Pipes would look like. We'd want to re-write this against the final API shape that we shipped with (this test in corefxlab was written against the prototype code/API). I will re-write this and share the sample this week (just a heads up in case you were interested in giving it a shot).
The write side is in WriteToPipTests.cs.
We're not shipping anything that targets frameworks prior to
netstandard2.0, so no point to compiling corefxlab projects for those frameworks.This PR also updates the SDK used by corefxlab to .NET Core 3.0 RTM, which also means that System.Text.Json is now built-in and all of the old JsonLab tests and dependent projects are failing due to API changes and type name collisions. Since we've already shipped System.Text.Json, I've removed JsonLab and related projects entirely as part of this PR.