Fix BodyNotFoundException in MockResponsePlugin #1409
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In version 1.2.0 when configuring the MockResponsePlugin, it is not possible to return a mocked response for a GET request (or any request without a body).
Steps to reproduce
Use a mock.json example from https://learn.microsoft.com/en-us/microsoft-cloud/dev/dev-proxy/how-to/mock-responses. For example:
Sending a request to this configured URL with "curl" causes the plugin to fail to process the request and just pass the request to the actual host.
Issue
This is caused by an
Titanium.Web.Proxy.Exceptions.BodyNotFoundException
in the first if-statement in theReplacePlaceholders
method of the MockResponsePlugin class, when trying to read the propertyBodyString
on the request object.Fix
To prevent processing a body that is not present, the condition that causes the exception can be replaced with
!response.HasBody
, as it semantically means the same.