Skip to content

Conversation

bartizan
Copy link
Contributor

@bartizan bartizan marked this pull request as ready for review October 13, 2025 08:21
@bartizan bartizan requested a review from a team as a code owner October 13, 2025 08:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the MinimalPermissionsGuidancePlugin to support different security scheme types (delegated and application permissions) by adding a configurable schemeName parameter. This allows the plugin to distinguish between different permission types when analyzing API calls and reporting minimal permissions.

Key changes:

  • Added schemeName configuration option to specify the security scheme for permission analysis
  • Updated reporting to include the scheme name in output headers and messages
  • Modified permission checking logic to pass the scheme name through the analysis pipeline

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
schemas/v1.3.0/minimalpermissionsguidanceplugin.schema.json Added schemeName property to plugin configuration schema
DevProxy.Plugins/Reporting/MinimalPermissionsGuidancePluginReport.cs Updated report generation to conditionally include scheme name in headers
DevProxy.Plugins/Reporting/MinimalPermissionsGuidancePlugin.cs Added scheme name configuration, updated permission checking calls, and enhanced logging with scheme-specific messages

Copy link
Collaborator

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Nothing to add.

@waldekmastykarz waldekmastykarz merged commit ed116cc into dotnet:main Oct 17, 2025
4 checks passed
@bartizan bartizan deleted the 1393_add-schemeName-to-MinimalPermissionsGuidancePlugin branch October 17, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants