Make xref archive download test hermetic - #11092
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 18, 2026
vicancy
added a commit
to sergimos/docfx
that referenced
this pull request
Sep 18, 2026
Reuse the existing main-branch fix from dotnet#11092 on this older PDF branch. Keep real local xref loading, archive generation, and parsed-content assertions while removing the live HTTP dependency. Full main synchronization could not be pushed because the OAuth credential lacks workflow scope. (cherry picked from commit 794b5d6) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 37887675-2b86-4eb0-b0f4-94f8ed759c8c
This was referenced Sep 18, 2026
vicancy
added a commit
that referenced
this pull request
Sep 18, 2026
* feat(pdf): allow footer and header to be printed on the cover page and toc pages * Update heading size in documentation * Revert package-lock.json * test(pdf): verify cover and TOC header/footer rendering Render real PDFs through Docset.Build and Docset.Pdf and inspect page text, margin glyphs, numbering and bookmarks for default and independent opt-in behavior. Document defaults and numbering semantics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 37887675-2b86-4eb0-b0f4-94f8ed759c8c * test: inherit hermetic xref archive download fixture Reuse the existing main-branch fix from #11092 on this older PDF branch. Keep real local xref loading, archive generation, and parsed-content assertions while removing the live HTTP dependency. Full main synchronization could not be pushed because the OAuth credential lacks workflow scope. (cherry picked from commit 794b5d6) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 37887675-2b86-4eb0-b0f4-94f8ed759c8c * fix(pdf): cache headers and footers by page geometry Keep static templates rendered for differently sized or oriented pages separate, including a landscape cover followed by portrait TOC and article pages. Add real PDF margin-position regressions for standard and custom cover sizes and preserve all existing flag/default cases. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 37887675-2b86-4eb0-b0f4-94f8ed759c8c --------- Co-authored-by: Ferreira Sergio <sergio.ferreira@skan.ch> Co-authored-by: Liangying.Wei <lianwei@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 37887675-2b86-4eb0-b0f4-94f8ed759c8c
This was referenced Sep 18, 2026
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotnet.github.ioxrefmap request with a minimal local fixtureValidation
dotnet test test\Docfx.Build.Tests\Docfx.Build.Tests.csproj --no-build --no-restore --framework net8.0 --filter "FullyQualifiedName=Docfx.Build.Engine.Tests.XRefArchiveBuilderTest.TestDownload" --verbosity minimal(1 passed)