Skip to content

Add a warning about perfcollect Lttng incompatibility #45776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2025
Merged

Add a warning about perfcollect Lttng incompatibility #45776

merged 5 commits into from
Apr 12, 2025

Conversation

noahfalk
Copy link
Member

@noahfalk noahfalk commented Apr 10, 2025 •
edited by github-actions bot
Loading

@noahfalk noahfalk requested review from tommcdon and a team as code owners April 10, 2025 22:35
@dotnetrepoman dotnetrepoman bot added this to the April 2025 milestone Apr 10, 2025
@CamSoper CamSoper changed the base branch from perfcollect_lttng_warning to main April 11, 2025 00:06
CamSoper
CamSoper approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, @noahfalk. I also took the opportunity to fix the markdown. Through no fault of yours, the markdown in that file was sloppy and causing linting issues.

Are you ready for us to merge or should we wait for a review from @tommcdon?

@CamSoper CamSoper self-assigned this Apr 11, 2025
@noahfalk
Copy link
Member Author

I actually meant to add @brianrob just to double check I am describing this accurately so lets wait for him to take a look.

thanks @CamSoper!

@noahfalk noahfalk requested a review from brianrob April 11, 2025 08:26
@CamSoper
Copy link
Contributor

@noahfalk Sure thing! Please @ me when he reviews in case I miss it.

brianrob
brianrob approved these changes Apr 12, 2025
View reviewed changes
Copy link
Member

@brianrob brianrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @noahfalk!

@gewarren gewarren enabled auto-merge (squash) April 12, 2025 01:24
@noahfalk
Copy link
Member Author

@CamSoper - Brian reviewed, we are good to go here

@gewarren gewarren closed this Apr 12, 2025
auto-merge was automatically disabled April 12, 2025 16:20

Pull request was closed

@gewarren gewarren reopened this Apr 12, 2025
@gewarren gewarren merged commit 240ecce into dotnet:main Apr 12, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CamSoper CamSoper CamSoper approved these changes

@brianrob brianrob brianrob approved these changes

@tommcdon tommcdon Awaiting requested review from tommcdon tommcdon is a code owner

Assignees

@CamSoper CamSoper

Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
April 2025
Development

Successfully merging this pull request may close these issues.
4 participants
@noahfalk @CamSoper @brianrob @gewarren