-
Notifications
You must be signed in to change notification settings - Fork 6k
Move unmanaged APIs for Metadata to /core folder #46991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: gewarren <[email protected]>
Co-authored-by: gewarren <[email protected]>
Co-authored-by: gewarren <[email protected]>
@copilot There are some invalid link warnings in the build report. Can you access the build report? If so, please fix them. |
Co-authored-by: gewarren <[email protected]>
I've identified and fixed the invalid link warnings in the build report. The issue was that 723 files in the moved API documentation were referencing |
@copilot There are more build errors to fix, for example, in the file assemblybindinfo-structure.md, there's the following warning:
|
Co-authored-by: gewarren <[email protected]>
Fixed the invalid link warnings in all 723 moved API documentation files. The issue was that the links were incorrectly pointing to |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: gewarren <[email protected]>
... Fixed all remaining build warnings for invalid file links. The issue was that the relative path to |
Many of these APIs are not supported or are missing in .NET Core. For example, everything that starts with CEE... is not available in .NET Core. I do not think this should be a wholesale move. |
I think we want to only move |
This is finally ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
docs/core/unmanaged-api/metadata/enumerations/assemblyflags-enumeration.md
Outdated
Show resolved
Hide resolved
docs/core/unmanaged-api/metadata/enumerations/assemblyflags-enumeration.md
Outdated
Show resolved
Hide resolved
docs/core/unmanaged-api/metadata/enumerations/assemblyflags-enumeration.md
Outdated
Show resolved
Hide resolved
docs/core/unmanaged-api/metadata/enumerations/assemblyrefflags-enumeration.md
Show resolved
Hide resolved
docs/core/unmanaged-api/metadata/enumerations/corassemblyflags-enumeration.md
Outdated
Show resolved
Hide resolved
docs/core/unmanaged-api/metadata/enumerations/corgenericparamattr-enumeration.md
Outdated
Show resolved
Hide resolved
docs/core/unmanaged-api/metadata/enumerations/corgenericparamattr-enumeration.md
Show resolved
Hide resolved
.../core/unmanaged-api/metadata/interfaces/imetadataconverter-getmetadatafromtypeinfo-method.md
Outdated
Show resolved
Hide resolved
.../core/unmanaged-api/metadata/interfaces/imetadatadispenserex-getcorsystemdirectory-method.md
Outdated
Show resolved
Hide resolved
Thank you for the detailed review @jkotas! |
Since they can be used on both .NET and .NET Framework, this PR moves unmanaged APIs for Metadata from the
/docs/**framework**/unmanaged-api/
folder to the/docs/**core**/unmanaged-api/
folder, following the pattern established in PR #37206 for debugging and profiling APIs.Changes Made
APIs Moved
Documentation Updates
/docs/core/unmanaged-api/index.md
as the main landing page for cross-platform unmanaged APIs/docs/framework/unmanaged-api/index.md
to clarify it's for .NET Framework-specific APIs and added cross-references to moved contenttoc.yml
) files for the new core structureCross-Reference Fixes
Updated internal links in the following files to point to the new locations:
docs/fundamentals/reflection/emitting-dynamic-methods-and-assemblies.md
docs/fundamentals/runtime-libraries/system-threading-thread.md
Contributes to #37227.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews
Toggle expand/collapse
Note
This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.