Fix JSON deserialization errors in C# 'REST Client' tutorial. Closes … #49442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#49387 Fix the deserialization issue in the Repository model.
dotnet-policy-service
bot
added
dotnet-csharp/svc
fundamentals/subsvc
community-contribution
Updated the Repository class definition to use a record type with additional properties for JSON deserialization.
|
@dotnet-policy-service agree |
Removed LastPush property and its implementation.
|
Let's wait for @BillWagner review. |
Clarified JSON property name handling and added note on case insensitivity of GetFromJsonAsync.
BillWagner
approved these changes
Oct 24, 2025
There was a problem hiding this comment.
Thanks @mozhganEtaati
And @StuartMosquera
This looks great, and I'll 
now.
BillWagner
reviewed
Oct 24, 2025
Co-authored-by: Bill Wagner <[email protected]>
Co-authored-by: Bill Wagner <[email protected]>
|
@BillWagner |
Hi, @mozhganEtaati Nothing is blocking it now. I'll merge. Thanks for making the updates based on the earlier review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#49387
Fix the deserialization issue in the Repository model.
Summary
Corrected property names in the Repository model to match the JSON fields returned by the GitHub API.
GitHubHomeUrl → maps to html_url
LastPushUtc → maps to pushed_at
Fixes #49387
Internal previews