Skip to content

Conversation

@meaghanlewis
Copy link
Contributor

@meaghanlewis meaghanlewis commented Oct 27, 2025

Summary

This pull request makes a minor documentation update by removing a redundant section heading from the metrics generator documentation.

Fixes #49455


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/metrics-generator.md Compile-time metric source generation

@dotnetrepoman dotnetrepoman bot added this to the October 2025 milestone Oct 27, 2025
@meaghanlewis meaghanlewis marked this pull request as ready for review October 27, 2025 22:59
@meaghanlewis meaghanlewis requested review from a team and tommcdon as code owners October 27, 2025 22:59
Copilot AI review requested due to automatic review settings October 27, 2025 22:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes a duplicate section heading from the metrics generator documentation. The heading "Metric methods are constrained to the following:" was incorrectly repeated immediately after a list item describing the first parameter constraint.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

@meaghanlewis meaghanlewis merged commit d0e1196 into dotnet:main Oct 28, 2025
11 checks passed
@meaghanlewis meaghanlewis deleted the remove-duplicate-sentence branch October 28, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unfinished sentence on page dotnet/core/diagnostics/metrics-generator

2 participants