Port System.Drawing docs for .NET 9 #10243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-Meta
dotnet-policy-service
bot
added
the
community-contribution
|
cc: @JeremyKuhne , @carlossanlop , @merriemcgaw , @gewarren |
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
reviewed
Aug 14, 2024
There was a problem hiding this comment.
I left a couple suggestions. This pattern should be followed throughout. (For API writing guidelines, see https://github.com/dotnet/dotnet-api-docs/wiki/API-docs-writing-guidelines.)
xml/System.Drawing.Imaging.Effects/BlackSaturationCurveEffect.xml
Outdated
Show resolved
Hide resolved
xml/System.Drawing.Imaging.Effects/BrightnessContrastEffect.xml
Outdated
Show resolved
Hide resolved
xml/System.Drawing.Imaging.Effects/BrightnessContrastEffect.xml
Outdated
Show resolved
Hide resolved
xml/System.Drawing.Imaging.Effects/BrightnessContrastEffect.xml
Outdated
Show resolved
Hide resolved
xml/System.Drawing.Imaging.Effects/BrightnessContrastEffect.xml
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@lonitra I fixed the If I get a review, I can merge it and you can update your installed tool by running the Apologies for all the noise. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
reviewed
Aug 27, 2024
xml/System.Drawing.Imaging.Effects/BrightnessContrastEffect.xml
Outdated
Show resolved
Hide resolved
xml/System.Drawing.Imaging.Effects/BrightnessContrastEffect.xml
Outdated
Show resolved
Hide resolved
xml/System.Drawing.Imaging.Effects/BrightnessContrastEffect.xml
Outdated
Show resolved
Hide resolved
lonitra
commented
Aug 27, 2024
lonitra
commented
Aug 27, 2024
Co-authored-by: Genevieve Warren <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
approved these changes
Aug 28, 2024
Co-authored-by: Genevieve Warren <[email protected]>
|
Learn Build status updates of commit d525201: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. For any questions, please:
|
|
@gewarren I don't have the ability to merge PR. Could you merge if everything looks good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dotnet/winforms#11858
Followed porting instructions in main issue