Add project file and modernize code #10975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
This comment was marked as outdated.
This comment was marked as outdated.
BillWagner
approved these changes
Feb 19, 2025
snippets/csharp/System/NullReferenceException/Overview/Array1.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System/NullReferenceException/Overview/Array2.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System/NullReferenceException/Overview/Chain1.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System/NullReferenceException/Overview/Chain1.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System/NullReferenceException/Overview/Chain2.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+9
to
+10
| Page current = pages.CurrentPage; | ||
| if (current != null) |
There was a problem hiding this comment.
Something here seems off if nullable references are enabled. Either current should be a Page? or the null check isn't needed.
There was a problem hiding this comment.
I have now explicitly disabled nullable context for the purpose of the examples. Can you review my most recent commit, especially the note I added to the NRE examples in the .xml file?
snippets/csharp/System/NullReferenceException/Overview/nullreturn2.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System/NullReferenceException/Overview/nullreturn2a.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Bill Wagner <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created this PR to allow #10967 to pass status checks.
(Hide whitespace changes.)