Skip to content

Replace private property with public one #11041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Replace private property with public one #11041

merged 2 commits into from
Mar 5, 2025

Conversation

am11
Copy link
Member

@am11 am11 commented Mar 3, 2025

This can be merged together with dotnet/sdk#47141.

@am11 am11 requested a review from a team as a code owner March 3, 2025 11:22
@am11
Copy link
Member Author

am11 commented Mar 3, 2025

cc @wfurt, @rzikm

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 3, 2025
Copy link

Learn Build status updates of commit ebe2b64:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net/NetworkCredential.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@gewarren gewarren enabled auto-merge (squash) March 5, 2025 20:48
Copy link

Learn Build status updates of commit b89bdad:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net/NetworkCredential.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 905ec6b into dotnet:main Mar 5, 2025
4 checks passed
@am11
Copy link
Member Author

am11 commented Mar 5, 2025

@gewarren, thanks, could you please merge upstream PR as well dotnet/sdk#47141? I don't have write access.

@am11 am11 deleted the patch-2 branch March 5, 2025 21:57
gewarren added a commit that referenced this pull request Mar 5, 2025
@gewarren
Copy link
Contributor

gewarren commented Mar 5, 2025

@gewarren, thanks, could you please merge upstream PR as well dotnet/sdk#47141? I don't have write access.

Oh, no I'm not the expert on that repo, so we'll have to wait for the networking team to accept the change. I'll revert this PR.

gewarren added a commit that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants