-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add missing exception info for HttpClient
and SocketsHttpHandler
properties
#11043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing exception info for HttpClient
and SocketsHttpHandler
properties
#11043
Conversation
Tagging subscribers to this area: @dotnet/ncl |
Learn Build status updates of commit a92e85b: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
xml/System.Net.Http/HttpClient.xml
xml/System.Net.Http/SocketsHttpHandler.xml
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Learn Build status updates of commit 84ad1e1: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit.
Co-authored-by: Genevieve Warren <[email protected]>
Learn Build status updates of commit bf1a7e9: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
I went through all
HttpClient
andSocketsHttpHandler
properties harmonizing the exception docs with the actual implementation.I didn't touch
HttpClientHandler
docs, because most property setters are forwareded to the underlying handler, making it hard to provide comprehensive and reliable docs.Fixes #10962