-
Notifications
You must be signed in to change notification settings - Fork 1.6k
SHA256 spelling fix #11062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHA256 spelling fix #11062
Conversation
Learn Build status updates of commit 3af6278: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Thank you @hawkeye101. I want to figure out what the correct spelling is first (I left a question in the issue). Also, we'll probably need to update the SHA256 class docs as well. |
In general, I would expect SHA-256 when referring to the algorithm, and It gets a little messier because SHA-2-256 is also acceptable, but in general I think it should only be used when disambiguating SHA-2-256 and SHA-3-256. We should also address any inconsistencies with SHA384/SHA-384 and SHA512/SHA-512. I suspect they inherited any documentation inconsistencies. @bartonjs likely has thoughts, too. |
I, personally, prefer always using "SHA-2-256" over "SHA-256", but I'm a pedant. Kevin's suggested "SHA256" is the class, "SHA-256" is the algorithm is probably the best starting place. Anything that already says "SHA-2-256" probably isn't worth changing since they'd have to be read to see if they're excluding (or contradistincting against) "SHA-3-256". |
@gewarren Here is what I've understood. Just want to confirm before I make the changes.
These are the only changes required as far as I understand. Please let me know if there are more (like HMACSHA3 classes) |
@hawkeye101 Those changes look correct to me. There are likely additional changes required, but that would require additional research. |
Thank you @hawkeye101. I'm going to close this in favor of the more comprehensive #11104. |
#11023
Replaced 'SHA-256' with 'SHA256'.