Skip to content

(More) fix that/which grammar #11142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xml/System.Linq.Expressions/BinaryExpression.xml
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@
## Remarks
If CanReduce returns true, this should return a valid expression.

This method can return another node which itself must be reduced.
This method can return another node that itself must be reduced.

]]></format>
</remarks>
Expand Down
8 changes: 4 additions & 4 deletions xml/System.Linq.Expressions/Expression.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9551,7 +9551,7 @@ As with `Func`, the last argument is the return type. It can be set to `System.V
<Parameter Name="target" Type="System.Linq.Expressions.LabelTarget" Index="0" FrameworkAlternate="dotnet-uwp-10.0;net-10.0;net-5.0;net-6.0;net-7.0;net-8.0;net-9.0;netcore-1.0;netcore-1.1;netcore-2.0;netcore-2.1;netcore-2.2;netcore-3.0;netcore-3.1;netframework-4.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8;netframework-4.8.1;netstandard-1.0;netstandard-1.1;netstandard-1.2;netstandard-1.3;netstandard-1.4;netstandard-1.6;netstandard-2.0;netstandard-2.1" />
</Parameters>
<Docs>
<param name="target">The <see cref="T:System.Linq.Expressions.LabelTarget" /> which this <see cref="T:System.Linq.Expressions.LabelExpression" /> will be associated with.</param>
<param name="target">The <see cref="T:System.Linq.Expressions.LabelTarget" /> that this <see cref="T:System.Linq.Expressions.LabelExpression" /> will be associated with.</param>
<summary>Creates a <see cref="T:System.Linq.Expressions.LabelExpression" /> representing a label without a default value.</summary>
<returns>A <see cref="T:System.Linq.Expressions.LabelExpression" /> without a default value.</returns>
<remarks>To be added.</remarks>
Expand Down Expand Up @@ -9722,7 +9722,7 @@ As with `Func`, the last argument is the return type. It can be set to `System.V
</Parameter>
</Parameters>
<Docs>
<param name="target">The <see cref="T:System.Linq.Expressions.LabelTarget" /> which this <see cref="T:System.Linq.Expressions.LabelExpression" /> will be associated with.</param>
<param name="target">The <see cref="T:System.Linq.Expressions.LabelTarget" /> that this <see cref="T:System.Linq.Expressions.LabelExpression" /> will be associated with.</param>
<param name="defaultValue">The value of this <see cref="T:System.Linq.Expressions.LabelExpression" /> when the label is reached through regular control flow.</param>
<summary>Creates a <see cref="T:System.Linq.Expressions.LabelExpression" /> representing a label with the given default value.</summary>
<returns>A <see cref="T:System.Linq.Expressions.LabelExpression" /> with the given default value.</returns>
Expand Down Expand Up @@ -20051,7 +20051,7 @@ As with `Func`, the last argument is the return type. It can be set to `System.V
</ReturnValue>
<Parameters />
<Docs>
<summary>Reduces this node to a simpler expression. If CanReduce returns true, this should return a valid expression. This method can return another node which itself must be reduced.</summary>
<summary>Reduces this node to a simpler expression. If CanReduce returns true, this should return a valid expression. This method can return another node that itself must be reduced.</summary>
<returns>The reduced expression.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -20094,7 +20094,7 @@ As with `Func`, the last argument is the return type. It can be set to `System.V
</ReturnValue>
<Parameters />
<Docs>
<summary>Reduces this node to a simpler expression. If CanReduce returns true, this should return a valid expression. This method can return another node which itself must be reduced.</summary>
<summary>Reduces this node to a simpler expression. If CanReduce returns true, this should return a valid expression. This method can return another node that itself must be reduced.</summary>
<returns>The reduced expression.</returns>
<remarks>
<format type="text/markdown"><![CDATA[
Expand Down
4 changes: 2 additions & 2 deletions xml/System.Linq.Expressions/LabelExpression.xml
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,8 @@
<ReturnType>System.Linq.Expressions.LabelTarget</ReturnType>
</ReturnValue>
<Docs>
<summary>The <see cref="T:System.Linq.Expressions.LabelTarget" /> which this label is associated with.</summary>
<value>The <see cref="T:System.Linq.Expressions.LabelTarget" /> which this label is associated with.</value>
<summary>The <see cref="T:System.Linq.Expressions.LabelTarget" /> that this label is associated with.</summary>
<value>The <see cref="T:System.Linq.Expressions.LabelTarget" /> that this label is associated with.</value>
<remarks>To be added.</remarks>
</Docs>
</Member>
Expand Down
4 changes: 2 additions & 2 deletions xml/System.Linq.Expressions/LambdaExpression.xml
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@
<Parameter Name="method" Type="System.Reflection.Emit.MethodBuilder" Index="0" FrameworkAlternate="netframework-4.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8;netframework-4.8.1" />
</Parameters>
<Docs>
<param name="method">A <see cref="T:System.Reflection.Emit.MethodBuilder" /> which will be used to hold the lambda's IL.</param>
<param name="method">A <see cref="T:System.Reflection.Emit.MethodBuilder" /> that will be used to hold the lambda's IL.</param>
<summary>Compiles the lambda into a method definition.</summary>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -360,7 +360,7 @@
<Parameter Name="debugInfoGenerator" Type="System.Runtime.CompilerServices.DebugInfoGenerator" Index="1" FrameworkAlternate="netframework-4.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8;netframework-4.8.1" />
</Parameters>
<Docs>
<param name="method">A <see cref="T:System.Reflection.Emit.MethodBuilder" /> which will be used to hold the lambda's IL.</param>
<param name="method">A <see cref="T:System.Reflection.Emit.MethodBuilder" /> that will be used to hold the lambda's IL.</param>
<param name="debugInfoGenerator">Debugging information generator used by the compiler to mark sequence points and annotate local variables.</param>
<summary>Compiles the lambda into a method definition and custom debug information.</summary>
<remarks>To be added.</remarks>
Expand Down
42 changes: 21 additions & 21 deletions xml/System.Linq.Expressions/ListInitExpression.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,21 +57,21 @@
<Docs>
<summary>Represents a constructor call that has a collection initializer.</summary>
<remarks>
<format type="text/markdown"><![CDATA[
## Remarks
Use the <xref:System.Linq.Expressions.Expression.ListInit%2A> factory methods to create a <xref:System.Linq.Expressions.ListInitExpression>.
The value of the <xref:System.Linq.Expressions.Expression.NodeType%2A> property of a <xref:System.Linq.Expressions.ListInitExpression> is <xref:System.Linq.Expressions.ExpressionType.ListInit>.
## Examples
The following example creates a <xref:System.Linq.Expressions.ListInitExpression> that represents the initialization of a new dictionary instance that has two key-value pairs.
<format type="text/markdown"><![CDATA[

## Remarks
Use the <xref:System.Linq.Expressions.Expression.ListInit%2A> factory methods to create a <xref:System.Linq.Expressions.ListInitExpression>.

The value of the <xref:System.Linq.Expressions.Expression.NodeType%2A> property of a <xref:System.Linq.Expressions.ListInitExpression> is <xref:System.Linq.Expressions.ExpressionType.ListInit>.



## Examples
The following example creates a <xref:System.Linq.Expressions.ListInitExpression> that represents the initialization of a new dictionary instance that has two key-value pairs.

:::code language="csharp" source="~/snippets/csharp/System.Linq.Expressions/BinaryExpression/Overview/Expression.cs" id="Snippet7":::
:::code language="vb" source="~/snippets/visualbasic/VS_Snippets_CLR_System/system.Linq.Expressions.Expression/VB/Expression.vb" id="Snippet7":::
:::code language="vb" source="~/snippets/visualbasic/VS_Snippets_CLR_System/system.Linq.Expressions.Expression/VB/Expression.vb" id="Snippet7":::

]]></format>
</remarks>
</Docs>
Expand Down Expand Up @@ -346,13 +346,13 @@
<summary>Reduces the binary expression node to a simpler expression.</summary>
<returns>The reduced expression.</returns>
<remarks>
<format type="text/markdown"><![CDATA[
## Remarks
If the `CanReduce` method returns true, this method should return a valid expression.
This method is allowed to return another node which itself must be reduced.
<format type="text/markdown"><![CDATA[

## Remarks
If the `CanReduce` method returns true, this method should return a valid expression.

This method is allowed to return another node that itself must be reduced.

]]></format>
</remarks>
</Docs>
Expand Down
42 changes: 21 additions & 21 deletions xml/System.Linq.Expressions/MemberInitExpression.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,21 +57,21 @@
<Docs>
<summary>Represents calling a constructor and initializing one or more members of the new object.</summary>
<remarks>
<format type="text/markdown"><![CDATA[
## Remarks
Use the <xref:System.Linq.Expressions.Expression.MemberInit%2A> factory methods to create a <xref:System.Linq.Expressions.MemberInitExpression>.
The value of the <xref:System.Linq.Expressions.Expression.NodeType%2A> property of a <xref:System.Linq.Expressions.MemberInitExpression> is <xref:System.Linq.Expressions.ExpressionType.MemberInit>.
## Examples
The following example creates a <xref:System.Linq.Expressions.MemberInitExpression> that represents the initialization of two members of a new object.
<format type="text/markdown"><![CDATA[

## Remarks
Use the <xref:System.Linq.Expressions.Expression.MemberInit%2A> factory methods to create a <xref:System.Linq.Expressions.MemberInitExpression>.

The value of the <xref:System.Linq.Expressions.Expression.NodeType%2A> property of a <xref:System.Linq.Expressions.MemberInitExpression> is <xref:System.Linq.Expressions.ExpressionType.MemberInit>.



## Examples
The following example creates a <xref:System.Linq.Expressions.MemberInitExpression> that represents the initialization of two members of a new object.

:::code language="csharp" source="~/snippets/csharp/System.Linq.Expressions/BinaryExpression/Overview/Expression.cs" id="Snippet9":::
:::code language="vb" source="~/snippets/visualbasic/VS_Snippets_CLR_System/system.Linq.Expressions.Expression/VB/Expression.vb" id="Snippet9":::
:::code language="vb" source="~/snippets/visualbasic/VS_Snippets_CLR_System/system.Linq.Expressions.Expression/VB/Expression.vb" id="Snippet9":::

]]></format>
</remarks>
</Docs>
Expand Down Expand Up @@ -346,13 +346,13 @@
<summary>Reduces the <see cref="T:System.Linq.Expressions.MemberInitExpression" /> to a simpler expression.</summary>
<returns>The reduced expression.</returns>
<remarks>
<format type="text/markdown"><![CDATA[
## Remarks
If the `CanReduce` method returns true, this method should return a valid expression.
This method is allowed to return another node which itself must be reduced.
<format type="text/markdown"><![CDATA[

## Remarks
If the `CanReduce` method returns true, this method should return a valid expression.

This method is allowed to return another node that itself must be reduced.

]]></format>
</remarks>
</Docs>
Expand Down
86 changes: 43 additions & 43 deletions xml/System.Linq.Expressions/UnaryExpression.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,33 +57,33 @@
<Docs>
<summary>Represents an expression that has a unary operator.</summary>
<remarks>
<format type="text/markdown"><![CDATA[
## Remarks
The following table summarizes the factory methods that can be used to create a <xref:System.Linq.Expressions.UnaryExpression> that has a specific node type.
|<xref:System.Linq.Expressions.Expression.NodeType%2A>|Factory Method|
|----------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------|
|<xref:System.Linq.Expressions.ExpressionType.ArrayLength>|<xref:System.Linq.Expressions.Expression.ArrayLength%2A>|
|<xref:System.Linq.Expressions.ExpressionType.Convert>|<xref:System.Linq.Expressions.Expression.Convert%2A>|
|<xref:System.Linq.Expressions.ExpressionType.ConvertChecked>|<xref:System.Linq.Expressions.Expression.ConvertChecked%2A>|
|<xref:System.Linq.Expressions.ExpressionType.Negate>|<xref:System.Linq.Expressions.Expression.Negate%2A>|
|<xref:System.Linq.Expressions.ExpressionType.NegateChecked>|<xref:System.Linq.Expressions.Expression.NegateChecked%2A>|
|<xref:System.Linq.Expressions.ExpressionType.Not>|<xref:System.Linq.Expressions.Expression.Not%2A>|
|<xref:System.Linq.Expressions.ExpressionType.Quote>|<xref:System.Linq.Expressions.Expression.Quote%2A>|
|<xref:System.Linq.Expressions.ExpressionType.TypeAs>|<xref:System.Linq.Expressions.Expression.TypeAs%2A>|
|<xref:System.Linq.Expressions.ExpressionType.UnaryPlus>|<xref:System.Linq.Expressions.Expression.UnaryPlus%2A>|
In addition, the <xref:System.Linq.Expressions.Expression.MakeUnary%2A> methods can also be used to create a <xref:System.Linq.Expressions.UnaryExpression>. These factory methods can be used to create a <xref:System.Linq.Expressions.UnaryExpression> of any node type that represents a unary operation. The parameter of these methods that is of type <xref:System.Linq.Expressions.Expression.NodeType%2A> specifies the desired node type.
## Examples
The following example creates a <xref:System.Linq.Expressions.UnaryExpression> object that represents the reference conversion of a non-nullable integer expression to the nullable integer type.
<format type="text/markdown"><![CDATA[

## Remarks
The following table summarizes the factory methods that can be used to create a <xref:System.Linq.Expressions.UnaryExpression> that has a specific node type.

|<xref:System.Linq.Expressions.Expression.NodeType%2A>|Factory Method|
|----------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------|
|<xref:System.Linq.Expressions.ExpressionType.ArrayLength>|<xref:System.Linq.Expressions.Expression.ArrayLength%2A>|
|<xref:System.Linq.Expressions.ExpressionType.Convert>|<xref:System.Linq.Expressions.Expression.Convert%2A>|
|<xref:System.Linq.Expressions.ExpressionType.ConvertChecked>|<xref:System.Linq.Expressions.Expression.ConvertChecked%2A>|
|<xref:System.Linq.Expressions.ExpressionType.Negate>|<xref:System.Linq.Expressions.Expression.Negate%2A>|
|<xref:System.Linq.Expressions.ExpressionType.NegateChecked>|<xref:System.Linq.Expressions.Expression.NegateChecked%2A>|
|<xref:System.Linq.Expressions.ExpressionType.Not>|<xref:System.Linq.Expressions.Expression.Not%2A>|
|<xref:System.Linq.Expressions.ExpressionType.Quote>|<xref:System.Linq.Expressions.Expression.Quote%2A>|
|<xref:System.Linq.Expressions.ExpressionType.TypeAs>|<xref:System.Linq.Expressions.Expression.TypeAs%2A>|
|<xref:System.Linq.Expressions.ExpressionType.UnaryPlus>|<xref:System.Linq.Expressions.Expression.UnaryPlus%2A>|

In addition, the <xref:System.Linq.Expressions.Expression.MakeUnary%2A> methods can also be used to create a <xref:System.Linq.Expressions.UnaryExpression>. These factory methods can be used to create a <xref:System.Linq.Expressions.UnaryExpression> of any node type that represents a unary operation. The parameter of these methods that is of type <xref:System.Linq.Expressions.Expression.NodeType%2A> specifies the desired node type.



## Examples
The following example creates a <xref:System.Linq.Expressions.UnaryExpression> object that represents the reference conversion of a non-nullable integer expression to the nullable integer type.

:::code language="csharp" source="~/snippets/csharp/System.Linq.Expressions/BinaryExpression/Overview/Expression.cs" id="Snippet11":::
:::code language="vb" source="~/snippets/visualbasic/VS_Snippets_CLR_System/system.Linq.Expressions.Expression/VB/Expression.vb" id="Snippet11":::
:::code language="vb" source="~/snippets/visualbasic/VS_Snippets_CLR_System/system.Linq.Expressions.Expression/VB/Expression.vb" id="Snippet11":::

]]></format>
</remarks>
</Docs>
Expand Down Expand Up @@ -219,11 +219,11 @@
<value>
<see langword="true" /> if the node represents a lifted call; otherwise, <see langword="false" />.</value>
<remarks>
<format type="text/markdown"><![CDATA[
## Remarks
An operator call is *lifted* if the operator expects a non-nullable operand but a nullable operand is passed to it.
<format type="text/markdown"><![CDATA[

## Remarks
An operator call is *lifted* if the operator expects a non-nullable operand but a nullable operand is passed to it.

]]></format>
</remarks>
</Docs>
Expand Down Expand Up @@ -270,11 +270,11 @@
<value>
<see langword="true" /> if the operator's return type is lifted to a nullable type; otherwise, <see langword="false" />.</value>
<remarks>
<format type="text/markdown"><![CDATA[
## Remarks
An operator call is *lifted* if the operator expects a non-nullable operand but a nullable operand is passed to it. If the value of <xref:System.Linq.Expressions.UnaryExpression.IsLiftedToNull%2A> is `true`, the operator returns a nullable type and if the nullable operand evaluates to `null`, the operator returns `null`.
<format type="text/markdown"><![CDATA[

## Remarks
An operator call is *lifted* if the operator expects a non-nullable operand but a nullable operand is passed to it. If the value of <xref:System.Linq.Expressions.UnaryExpression.IsLiftedToNull%2A> is `true`, the operator returns a nullable type and if the nullable operand evaluates to `null`, the operator returns `null`.

]]></format>
</remarks>
</Docs>
Expand Down Expand Up @@ -471,13 +471,13 @@
<summary>Reduces the expression node to a simpler expression.</summary>
<returns>The reduced expression.</returns>
<remarks>
<format type="text/markdown"><![CDATA[
## Remarks
If the `CanReduce` method returns true, this should return a valid expression.
This method can return another node which itself must be reduced.
<format type="text/markdown"><![CDATA[

## Remarks
If the `CanReduce` method returns true, this should return a valid expression.

This method can return another node that itself must be reduced.

]]></format>
</remarks>
</Docs>
Expand Down
4 changes: 2 additions & 2 deletions xml/System.Linq/ParallelEnumerable.xml
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@
<Docs>
<param name="source">The input sequence.</param>
<summary>Enables treatment of a data source as if it were ordered, overriding the default of unordered. AsOrdered may only be invoked on non-generic sequences returned by AsParallel, ParallelEnumerable.Range, and ParallelEnumerable.Repeat.</summary>
<returns>The source sequence which will maintain the original ordering in the subsequent query operators.</returns>
<returns>The source sequence that will maintain the original ordering in the subsequent query operators.</returns>
<remarks>
<format type="text/markdown"><![CDATA[

Expand Down Expand Up @@ -860,7 +860,7 @@
<typeparam name="TSource">The type of elements of <paramref name="source" />.</typeparam>
<param name="source">The input sequence.</param>
<summary>Enables treatment of a data source as if it were ordered, overriding the default of unordered. AsOrdered may only be invoked on generic sequences returned by AsParallel, ParallelEnumerable.Range, and ParallelEnumerable.Repeat.</summary>
<returns>The source sequence which will maintain the original ordering in the subsequent query operators.</returns>
<returns>The source sequence that will maintain the original ordering in the subsequent query operators.</returns>
<remarks>
<format type="text/markdown"><![CDATA[

Expand Down
Loading