Skip to content

Add project file and modernize code #9770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2024
Merged

Add project file and modernize code #9770

merged 2 commits into from
Mar 28, 2024

Conversation

gewarren
Copy link
Contributor

Fixes snippets 5000 error in #9759

  • Add project file
  • Format code files
  • Modernize code

@gewarren gewarren requested a review from a team as a code owner March 27, 2024 18:39
@ghost ghost added the area-System.Runtime label Mar 27, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime

@gewarren gewarren mentioned this pull request Mar 27, 2024
Merged
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit f634375:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System/Random/Overview/array1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/booleans1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/booleans2.cs ✅Succeeded
snippets/csharp/System/Random/Overview/bytes1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/doublerange1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/doublerange2.cs ✅Succeeded
snippets/csharp/System/Random/Overview/doublerange3.cs ✅Succeeded
snippets/csharp/System/Random/Overview/long1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/next.cs ✅Succeeded View
snippets/csharp/System/Random/Overview/next1.cs ✅Succeeded View
snippets/csharp/System/Random/Overview/Next2.cs ✅Succeeded View
snippets/csharp/System/Random/Overview/next4.cs ✅Succeeded View
snippets/csharp/System/Random/Overview/nextbytes1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/nextdoubleex1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/nextex1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/project.csproj ✅Succeeded
snippets/csharp/System/Random/Overview/Random1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/Random2.cs ✅Succeeded View
snippets/csharp/System/Random/Overview/range1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/range2.cs ✅Succeeded
snippets/csharp/System/Random/Overview/same1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/threadsafeex1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/threadsafeex2.cs ✅Succeeded
snippets/csharp/System/Random/Overview/unique.cs ✅Succeeded
snippets/csharp/System/Random/Overview/uniquearray1.cs ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

BillWagner
BillWagner approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @gewarren

I had one suggestion to make the project consistent with the current .NET defaults. Then, let's :shipit:

@gewarren gewarren enabled auto-merge (squash) March 28, 2024 19:02
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit a5a02d4:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System/Random/Overview/array1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/booleans1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/booleans2.cs ✅Succeeded
snippets/csharp/System/Random/Overview/bytes1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/doublerange1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/doublerange2.cs ✅Succeeded
snippets/csharp/System/Random/Overview/doublerange3.cs ✅Succeeded
snippets/csharp/System/Random/Overview/long1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/next.cs ✅Succeeded View
snippets/csharp/System/Random/Overview/next1.cs ✅Succeeded View
snippets/csharp/System/Random/Overview/Next2.cs ✅Succeeded View
snippets/csharp/System/Random/Overview/next4.cs ✅Succeeded View
snippets/csharp/System/Random/Overview/nextbytes1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/nextdoubleex1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/nextex1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/project.csproj ✅Succeeded
snippets/csharp/System/Random/Overview/Random1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/Random2.cs ✅Succeeded View
snippets/csharp/System/Random/Overview/range1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/range2.cs ✅Succeeded
snippets/csharp/System/Random/Overview/same1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/threadsafeex1.cs ✅Succeeded
snippets/csharp/System/Random/Overview/threadsafeex2.cs ✅Succeeded
snippets/csharp/System/Random/Overview/unique.cs ✅Succeeded
snippets/csharp/System/Random/Overview/uniquearray1.cs ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit ba5b6bb into dotnet:main Mar 28, 2024
3 checks passed
@gewarren gewarren deleted the add-project branch March 28, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@gewarren gewarren

Labels
area-System.Runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @BillWagner