Skip to content

Update BitConverter.xml #9809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Update BitConverter.xml #9809

merged 1 commit into from
Apr 15, 2024

Conversation

colejohnson66
Copy link
Contributor

@colejohnson66 colejohnson66 commented Apr 14, 2024

Update the remarks table for class-level documentation.

Summary

Added XToUIntXXBits and UIntXXBitsToX method mentions for Single and Double, and added a row for Half. Also added some spacing in table source for ease of editing in the future.

Questions

With TryWriteBytes(Span<byte>, T) now existing, this table could further be altered to include a "serialize to bytes" column. Is this desired?

Alternatively, due to the expanding API surface, it could be argued that this table should just be removed?

Update remarks table for class-level documentation
@colejohnson66 colejohnson66 requested a review from a team as a code owner April 14, 2024 23:11
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 14, 2024
@ghost ghost added the area-System.Runtime label Apr 14, 2024
Copy link

Learn Build status updates of commit 21e644e:

✅ Validation status: passed

File Status Preview URL Details
xml/System/BitConverter.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren
Copy link
Contributor

Tagging @dotnet/area-system-runtime.

@gewarren gewarren merged commit 36cd913 into dotnet:main Apr 15, 2024
3 checks passed
@gewarren
Copy link
Contributor

Thanks @colejohnson66

@colejohnson66 colejohnson66 deleted the patch-1 branch April 15, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants