Skip to content

MailAddress: Clarify formatting elements versus details of them. #9837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

breyed
Copy link
Contributor

@breyed breyed commented Apr 22, 2024

The list showing what is supported includes some complete formats for MailAddress (e.g. the first bullet) and some formatting elements that are not “format” of a MailAddress (e.g. the last bullet). Additionally, some bullets describe one of the formatting elements, rather than being formatting elements of their own. This commit addresses both issues.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

The list showing what is supported includes some complete formats for MailAddress (e.g. the first bullet) and some formatting elements that are not “format” of a MailAddress (e.g. the last bullet). Additionally, some bullets describe one of the formatting elements, rather than being formatting elements of their own. This commit addresses both issues.
@breyed breyed requested a review from a team as a code owner April 22, 2024 18:22
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 22, 2024
@ghost ghost added the area-System.Net label Apr 22, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl

Copy link

Learn Build status updates of commit dbb1eb2:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Mail/MailAddress.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @breyed. I had a couple suggestions to improve this even further. What do you think?

Copy link
Contributor Author

@breyed breyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

Learn Build status updates of commit 14c83a1:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Mail/MailAddress.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit d4a3c0c into dotnet:main Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants