Skip to content

Delete 404 links to samples #9874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

Delete 404 links to samples #9874

merged 1 commit into from
May 3, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented May 2, 2024 •
edited
Loading

@gewarren gewarren requested a review from a team as a code owner May 2, 2024 21:34
@ghost
Copy link

ghost commented May 2, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 2, 2024
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 9e7bf4d:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO.Packaging/CertificateEmbeddingOption.xml ✅Succeeded View
xml/System.IO.Packaging/Package.xml ✅Succeeded View
xml/System.IO.Packaging/PackageDigitalSignatureManager.xml ✅Succeeded View
xml/System.IO.Packaging/PackageRelationshipSelector.xml ✅Succeeded View
xml/System.IO.Packaging/PackUriHelper.xml ✅Succeeded View
xml/System.IO.Packaging/VerifyResult.xml ✅Succeeded View
xml/System.IO.Packaging/ZipPackage.xml ✅Succeeded View
xml/System.IO.Packaging/ZipPackagePart.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

BillWagner
BillWagner approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

@gewarren gewarren merged commit b390547 into dotnet:main May 3, 2024
3 checks passed
@gewarren gewarren deleted the packaging branch May 3, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@gewarren gewarren

Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Creating a Package with a Digital Signature Sample" dead link
2 participants
@gewarren @BillWagner