-
Notifications
You must be signed in to change notification settings - Fork 1.6k
CI Update - Remove .NET Platform Extensions 1-5 monikers #9905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=428827&view=results source_repo.branch:old-extensions source_repo.url:https://apidrop.visualstudio.com/_git/binaries
This comment was marked as outdated.
This comment was marked as outdated.
Learn Build status updates of commit fc892fd:
|
Are the warnings false positives because of the removal? |
They're not really false positives. There are APIs that only existed in .NET Platform Extensions 1.0 and 1.1, for example, and now those URLs will 404. But I think that's okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Let's
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=428827&view=results
source_repo.branch:old-extensions
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Summary
Remove monikers for .NET Platform Extension 1.0, 1.1, 2.0, 2.1, 2.2, 3.0, 3.1, 5.