Skip to content

CI Update - Remove .NET Platform Extensions 1-5 monikers #9905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2024

Conversation

gewarren
Copy link
Contributor

Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=428827&view=results
source_repo.branch:old-extensions
source_repo.url:https://apidrop.visualstudio.com/_git/binaries

Summary

Remove monikers for .NET Platform Extension 1.0, 1.1, 2.0, 2.1, 2.2, 3.0, 3.1, 5.

 Build.Reason:Manual by Genevieve Warren
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=428827&view=results
 source_repo.branch:old-extensions
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries

This comment was marked as outdated.

Copy link

Learn Build status updates of commit fc892fd:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.Caching.Redis/RedisCacheOptions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Caching.StackExchangeRedis/RedisCacheOptions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.CommandLineUtils/AnsiConsole.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.CommandLineUtils/CommandArgument.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.CommandLineUtils/CommandLineApplication.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.CommandLineUtils/CommandOption.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.CommandLineUtils/CommandOptionType.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.CommandLineUtils/CommandParsingException.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.Configuration.UserSecrets/PathHelper.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Configuration/ConfigurationExtensions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.FileProviders.Physical/PhysicalFilesWatcher.xml ⚠️Warning View Details
xml/Microsoft.Extensions.FileProviders/FileSystemInfoHelper.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.FileProviders/PhysicalFileProvider.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Globalization/CultureInfoCache.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.Internal/GcNotification.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.Localization/IStringLocalizer.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Localization/ResourceManagerWithCultureStringLocalizer.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.Localization/StringLocalizer`1.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Logging.Abstractions.Internal/NullScope.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.Logging.Abstractions.Internal/TypeNameHelper.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/AzureAppServicesDiagnosticsLoggerProvider.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/AzureBlobLoggerProvider.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/AzureBlobSink.xml ⚠️Warning n/a (file deleted or renamed) Details
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BackgroundSink.xml ⚠️Warning n/a (file deleted or renamed) Details

This comment lists only the first 25 files in the pull request.

xml/Microsoft.Extensions.Caching.Redis/RedisCacheOptions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'StackExchange.Redis.ConfigurationOptions'.

xml/Microsoft.Extensions.Caching.StackExchangeRedis/RedisCacheOptions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'StackExchange.Redis.IConnectionMultiplexer'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'StackExchange.Redis.Profiling.ProfilingSession'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'StackExchange.Redis.ConfigurationOptions'.

xml/Microsoft.Extensions.CommandLineUtils/AnsiConsole.xml

  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/AnsiConsole.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.ansiconsole was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/AnsiConsole.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.ansiconsole.geterror was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/AnsiConsole.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.ansiconsole.getoutput was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/AnsiConsole.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.ansiconsole.originalforegroundcolor was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/AnsiConsole.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.ansiconsole.writeline was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/AnsiConsole.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.ansiconsole.writer was deleted without redirection. To avoid broken links, add a redirection.

xml/Microsoft.Extensions.CommandLineUtils/CommandArgument.xml

  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandArgument.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandargument was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandArgument.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandargument.-ctor was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandArgument.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandargument.description was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandArgument.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandargument.multiplevalues was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandArgument.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandargument.name was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandArgument.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandargument.showinhelptext was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandArgument.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandargument.value was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandArgument.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandargument.values was deleted without redirection. To avoid broken links, add a redirection.

xml/Microsoft.Extensions.CommandLineUtils/CommandLineApplication.xml

  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandLineApplication.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandlineapplication was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandLineApplication.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandlineapplication.allowargumentseparator was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandLineApplication.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandlineapplication.argument was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandLineApplication.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandlineapplication.arguments was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandLineApplication.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandlineapplication.command was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandLineApplication.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandlineapplication.commands was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/Microsoft.Extensions.CommandLineUtils/CommandLineApplication.xml with URL /dotnet/api/microsoft.extensions.commandlineutils.commandlineapplication.-ctor was deleted without redirection. To avoid broken links, add a redirection.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@BillWagner
Copy link
Member

Are the warnings false positives because of the removal?

@gewarren
Copy link
Contributor Author

Are the warnings false positives because of the removal?

They're not really false positives. There are APIs that only existed in .NET Platform Extensions 1.0 and 1.1, for example, and now those URLs will 404. But I think that's okay.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

@gewarren gewarren merged commit 2b6497e into main May 15, 2024
3 checks passed
@gewarren gewarren deleted the remove-old-extensions branch May 15, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants