Skip to content

Conversation

@wfurt
Copy link
Member

@wfurt wfurt commented Feb 10, 2023

This is follow-up on #792 and #797

While #792 improved runtime test runs, some were still failing - particularly parsing foreign numbers.
It seems like musl-locales package adds the missing definition (and locale -a work now just like glibc)

#797 added base 3.17 image. So I refactor this to use it as base instead of duplicating the package.
While helix may not need all the dev tools this is the structure we used in previous releases.
Investigation if we can string helix images would be probably separate effort.

@ghost ghost added the area-dockerfiles label Feb 10, 2023
@wtgodbe
Copy link
Member

wtgodbe commented Feb 10, 2023

Looks like we only have the helix dockerfile for 3.16, is just adding musl-locales sufficient there? I can make that change in #798

@wfurt
Copy link
Member Author

wfurt commented Feb 10, 2023

Looks like we only have the helix dockerfile for 3.16, is just adding musl-locales sufficient there? I can make that change in #798

yes, I think just adding the package should be sufficient. I'm going to run full runtime tests and I can comment on #798 when I know the results.

@wfurt wfurt merged commit 0e643c0 into main Feb 10, 2023
@richlander richlander deleted the alpine317 branch June 13, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants