[release/10.0.1xx] Source code updates from microsoft/vstest #3809
Conversation
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
| <PropertyGroup> | ||
| <!-- _git/vs-code-coverage dependencies --> | ||
| <MicrosoftInternalCodeCoveragePackageVersion>18.0.0-preview.25469.1</MicrosoftInternalCodeCoveragePackageVersion> | ||
| <MicrosoftInternalCodeCoveragePackageVersion>18.0.6</MicrosoftInternalCodeCoveragePackageVersion> |
There was a problem hiding this comment.
This does not affect dotnet, this is for VS insertion.
| <MicrosoftInternalCodeCoveragePackageVersion>18.0.6</MicrosoftInternalCodeCoveragePackageVersion> | ||
| <!-- dotnet/dotnet dependencies --> | ||
| <MicrosoftDiagnosticsNETCoreClientPackageVersion>0.2.0-preview.25476.104</MicrosoftDiagnosticsNETCoreClientPackageVersion> | ||
| <MicrosoftDiagnosticsNETCoreClientPackageVersion>0.2.0-preview.25479.115</MicrosoftDiagnosticsNETCoreClientPackageVersion> |
There was a problem hiding this comment.
This was automatic update from dotnet/dotnet, so not sure why it blocks the build here.
There was a problem hiding this comment.
Because it's pinned here https://github.com/dotnet/dotnet/pull/3809/files#diff-c1b405191bf88ac8d480e5a3b3d223cdb7d21b1580298b2c515d8c9c5e08cb05R9 to a specific version. vstest depends on diagnostics, but the pinning means that the version of diagnostics that is specified is not what the VMR is building, hence the pre-built.
The pinning should be removed for the NETCoreClient package.
| avoid introducing pre-builts. https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src | ||
| --> | ||
| <MicrosoftBuildFrameworkPackageVersion>17.8.3</MicrosoftBuildFrameworkPackageVersion> | ||
| <MicrosoftBuildFrameworkPackageVersion>17.11.48</MicrosoftBuildFrameworkPackageVersion> |
There was a problem hiding this comment.
This is update for compliance. It has no functional impact on the shipment.
|
I think we can wait on this. No critical need for 10.0.102 |
Note
This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/microsoft/vstest
Diff the source with this PR branch