Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix load order of ProjectStaging and restrict package version validation to only official builds #6041

Merged
merged 10 commits into from
Mar 26, 2025
Merged

Fix load order of ProjectStaging and restrict package version validation to only official builds #6041

merged 10 commits into from
Mar 26, 2025

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Mar 5, 2025 •
edited
Loading

Reinstate #5864.

@RussKie RussKie requested a review from a team as a code owner March 5, 2025 22:48
@RussKie RussKie changed the title Fix load order of ProjectStaging and restrict package version validat… Fix load order of ProjectStaging and restrict package version validation to only official builds Mar 5, 2025
@RussKie RussKie requested a review from joperezr March 5, 2025 22:48
@RussKie
Copy link
Member Author

RussKie commented Mar 5, 2025

Tested in in the internal CI leg as a normal and a release branches.

@RussKie RussKie requested review from a team as code owners March 11, 2025 23:42
@RussKie
Copy link
Member Author

RussKie commented Mar 11, 2025

Tested in https://dev.azure.com/dnceng/internal/_build/results?buildId=2660769 and compared artifacts to the latest release (9.3).

@RussKie RussKie force-pushed the fix_validation branch 3 times, most recently from a37fef3 to 0804d78 Compare March 12, 2025 23:02
joperezr
joperezr reviewed Mar 12, 2025
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the above comments, the rest of the changes look good to me. I'm assuming you've ran a stable build with this and validated that the right packages are still marked as prerelease?

@RussKie
Copy link
Member Author

RussKie commented Mar 12, 2025

Other than the above comments, the rest of the changes look good to me. I'm assuming you've ran a stable build with this and validated that the right packages are still marked as prerelease?

I'm running tests now.

@RussKie RussKie mentioned this pull request Mar 13, 2025
Merged
@RussKie RussKie requested a review from a team as a code owner March 18, 2025 00:58
joperezr
joperezr reviewed Mar 26, 2025
View reviewed changes
joperezr
joperezr approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of super minor comments, but this looks good to go otherwise. Thanks a lot for the hard work on this and on getting it back and enabled.

RussKie added 10 commits March 27, 2025 09:36
@RussKie
Fix load order of ProjectStaging and restrict package version validat…
aeffae8 
…ion to only official builds
@RussKie
Add "validation" branch which mirrors "release" but can be deleted
9b78c04
@RussKie
Revert "Merged PR 48132: Flowing dependencies and getting ready for 9…
9bb4a45 
….3 release"

This reverts commit 092d941.
@RussKie
fixup! Fix load order of ProjectStaging and restrict package version …
bdd9169 
…validation to only official builds
@RussKie
fixup! Fix load order of ProjectStaging and restrict package version …
ee25781 
…validation to only official builds
@RussKie
fixup! Fix load order of ProjectStaging and restrict package version …
b498b3c 
…validation to only official builds
@RussKie
fixup! Fix load order of ProjectStaging and restrict package version …
f5a07af 
…validation to only official builds
@RussKie
Revert "fixup! Fix load order of ProjectStaging and restrict package …
c7826a7 
…version validation to only official builds"

This reverts commit d953d0a.
@RussKie
fixup! Fix load order of ProjectStaging and restrict package version …
2a429da 
…validation to only official builds
@RussKie
fixup! Fix load order of ProjectStaging and restrict package version …
751d1ec 
…validation to only official builds
@RussKie RussKie enabled auto-merge (squash) March 26, 2025 22:41
@RussKie
Copy link
Member Author

RussKie commented Mar 26, 2025

Ok, the build is green, merging.

@RussKie RussKie merged commit dc5d2f4 into dotnet:main Mar 26, 2025
6 checks passed
@RussKie RussKie deleted the fix_validation branch March 26, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenyfedorov2 evgenyfedorov2 evgenyfedorov2 approved these changes

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

@joperezr joperezr joperezr approved these changes

Assignees

@RussKie RussKie

Labels
area-infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RussKie @MackinnonBuck @joperezr @evgenyfedorov2