Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Update dependencies from dotnet/aspnetcore #6132

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 17, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/aspnetcore

Microsoft Reviewers: Open in CodeFlow

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.Bcl.AsyncInterfaces: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Bcl.TimeProvider: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Caching.Abstractions: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Caching.Memory: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Configuration.Abstractions: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Configuration.Binder: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Configuration.Json: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Configuration: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.DependencyInjection.Abstractions: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.DependencyInjection: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Hosting.Abstractions: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Diagnostics: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Hosting: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Http: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Logging.Abstractions: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Logging.Configuration: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Logging.Console: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Logging: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Options.ConfigurationExtensions: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.Extensions.Options: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.NETCore.App.Ref: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.NETCore.App.Runtime.win-x64: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Collections.Immutable: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Configuration.ConfigurationManager: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Diagnostics.DiagnosticSource: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Diagnostics.PerformanceCounter: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.IO.Hashing: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.IO.Pipelines: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Memory.Data: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Net.Http.Json: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Numerics.Tensors: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Runtime.Caching: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Security.Cryptography.Pkcs: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Security.Cryptography.Xml: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Text.Encodings.Web: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Text.Json: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • System.Threading.Channels: from 10.0.0-preview.3.25128.5 to 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
    • Microsoft.EntityFrameworkCore.Sqlite: from 10.0.0-preview.3.25126.101 to 10.0.0-preview.4.25176.2 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)

…0250314.5

Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.SqlServer , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool
 From Version 10.0.0-preview.3.25151.1 -> To Version 10.0.0-preview.3.25164.5
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner March 17, 2025 05:03
@DeagleGross
Copy link

@RussKie @wtgodbe this fails on Microsoft.Extensions.Logging version diff: https://github.com/dotnet/extensions/pull/6132/checks?check_run_id=38865710405

bench/Libraries/Microsoft.Extensions.Telemetry.PerformanceTests/Microsoft.Extensions.Telemetry.PerformanceTests.csproj(0,0): error NU1605: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Detected package downgrade: Microsoft.Extensions.Logging from 10.0.0-preview.3.25163.6 to 10.0.0-preview.3.25128.5. Reference the package directly from the project to select a different version.
Microsoft.Extensions.Telemetry.PerformanceTests -> Microsoft.AspNetCore.Mvc.Testing 10.0.0-preview.3.25164.5 -> Microsoft.Extensions.Hosting 10.0.0-preview.3.25163.6 -> Microsoft.Extensions.Logging (>= 10.0.0-preview.3.25163.6)
Microsoft.Extensions.Telemetry.PerformanceTests -> Microsoft.Extensions.Logging (>= 10.0.0-preview.3.25128.5)

I see that version are updated manually and most probably are pinned to 9.0.3 for a reason.

What should we do? I guess we can't manually update the version to 10.0.0-preview.3.25163.6 here

@RussKie
Copy link
Member

RussKie commented Mar 17, 2025

@dotnet/dnceng @mmitche this is another instance of the incoherent flow, similar to #6059. Any thoughts?

@mmitche
Copy link
Member

mmitche commented Mar 18, 2025

PS C:\r\extensions> darc update-dependencies --coherency-only
Checking for coherency updates...
fail: Coherency updates failed for the following dependencies:  Unable to update System.Memory.Data to have coherency with Microsoft.AspNetCore.App.Runtime.win-x64: https://github.com/dotnet/aspnetcore @ 825daf664804598df9942499970bee5e0f2432d5 does not contain dependency System.Memory.Data
          - Add the dependency to https://github.com/dotnet/aspnetcore.
          - Pin the dependency.
          - Remove the CoherentParentDependency attribute.
        Unable to update System.Numerics.Tensors to have coherency with Microsoft.AspNetCore.App.Runtime.win-x64: https://github.com/dotnet/aspnetcore @ 825daf664804598df9942499970bee5e0f2432d5 does not contain dependency System.Numerics.Tensors
          - Add the dependency to https://github.com/dotnet/aspnetcore.
          - Pin the dependency.
          - Remove the CoherentParentDependency attribute.

@mmitche
Copy link
Member

mmitche commented Mar 18, 2025

Aspnetcore needs to get dependencies on System.Memory.Data and System.Numerics.Tensors

@mmitche
Copy link
Member

mmitche commented Mar 18, 2025

Normally the standard merge policy on a branch has a check for coherency. Your merge policy was just set up for successful checks. I've fixed that.

@RussKie
Copy link
Member

RussKie commented Mar 19, 2025

Thank you @mmitche!

radical and others added 2 commits March 21, 2025 19:04
…0250321.5

Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.SqlServer , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool
 From Version 10.0.0-preview.3.25151.1 -> To Version 10.0.0-preview.4.25171.5
wtgodbe pushed a commit to dotnet/aspnetcore that referenced this pull request Mar 24, 2025
@radical
Copy link
Member

radical commented Mar 24, 2025

test/Libraries/Microsoft.Extensions.Http.Diagnostics.Tests/Microsoft.Extensions.Http.Diagnostics.Tests.csproj(0,0): error NU1605: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Detected package downgrade: Microsoft.Extensions.Hosting from 10.0.0-preview.3.25167.9 to 10.0.0-preview.3.25128.5. Reference the package directly from the project to select a different version. 
 Microsoft.Extensions.Http.Diagnostics.Tests -> Microsoft.AspNetCore.Mvc.Testing 10.0.0-preview.4.25171.5 -> Microsoft.Extensions.Hosting (>= 10.0.0-preview.3.25167.9) 
 Microsoft.Extensions.Http.Diagnostics.Tests -> Microsoft.Extensions.Hosting (>= 10.0.0-preview.3.25128.5)

What would be the correct fix here? cc @RussKie

@RussKie
Copy link
Member

RussKie commented Mar 24, 2025

We need to wait for the new ingestion from dotnet/aspnetcore#61007.

I kicked it off...

…0250324.4

Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.SqlServer , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool
 From Version 10.0.0-preview.3.25151.1 -> To Version 10.0.0-preview.4.25174.4

Dependency coherency updates

Microsoft.Bcl.AsyncInterfaces,Microsoft.Bcl.TimeProvider,Microsoft.Extensions.Caching.Abstractions,Microsoft.Extensions.Caching.Memory,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Binder,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.Configuration,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.Diagnostics,Microsoft.Extensions.Hosting,Microsoft.Extensions.Http,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging.Configuration,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging,Microsoft.Extensions.Options.ConfigurationExtensions,Microsoft.Extensions.Options,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,System.Collections.Immutable,System.Configuration.ConfigurationManager,System.Diagnostics.DiagnosticSource,System.Diagnostics.PerformanceCounter,System.IO.Hashing,System.IO.Pipelines,System.Memory.Data,System.Net.Http.Json,System.Numerics.Tensors,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.Xml,System.Text.Encodings.Web,System.Text.Json,System.Threading.Channels,Microsoft.EntityFrameworkCore.Sqlite
 From Version 10.0.0-preview.3.25128.5 -> To Version 10.0.0-preview.3.25167.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64
@RussKie
Copy link
Member

RussKie commented Mar 24, 2025

I think we resolved the dependency hierarchy, and now we need to resolve

D:\a\_work\1\s\artifacts\obj\Microsoft.Extensions.AmbientMetadata.Application\Release\net10.0\Microsoft.Extensions.Options.SourceGeneration\Microsoft.Extensions.Options.Generators.OptionsValidatorGenerator\Validators.g.cs

@dotnet/dotnet-extensions-telemetry could you please give a hand?

dotnet-maestro bot and others added 2 commits March 31, 2025 05:02
…0250328.6

Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.SqlServer , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool
 From Version 10.0.0-preview.3.25151.1 -> To Version 10.0.0-preview.4.25178.6

Dependency coherency updates

Microsoft.Bcl.AsyncInterfaces,Microsoft.Bcl.TimeProvider,Microsoft.Extensions.Caching.Abstractions,Microsoft.Extensions.Caching.Memory,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Binder,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.Configuration,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.Diagnostics,Microsoft.Extensions.Hosting,Microsoft.Extensions.Http,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging.Configuration,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging,Microsoft.Extensions.Options.ConfigurationExtensions,Microsoft.Extensions.Options,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,System.Collections.Immutable,System.Configuration.ConfigurationManager,System.Diagnostics.DiagnosticSource,System.Diagnostics.PerformanceCounter,System.IO.Hashing,System.IO.Pipelines,System.Memory.Data,System.Net.Http.Json,System.Numerics.Tensors,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.Xml,System.Text.Encodings.Web,System.Text.Json,System.Threading.Channels,Microsoft.EntityFrameworkCore.Sqlite
 From Version 10.0.0-preview.3.25128.5 -> To Version 10.0.0-preview.4.25177.9 (parent: Microsoft.AspNetCore.App.Runtime.win-x64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants