Add Windows disk I/O metrics to ResourceMonitoring #6181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makazeu
changed the title
RussKie
reviewed
Mar 24, 2025
...ns.Diagnostics.ResourceMonitoring/Microsoft.Extensions.Diagnostics.ResourceMonitoring.csproj
Show resolved
Hide resolved
...ies/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ResourceMonitoringOptions.Windows.cs
Outdated
Show resolved
Hide resolved
...aries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Windows/Disk/WindowsDiskMetrics.cs
Outdated
Show resolved
Hide resolved
...aries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Windows/Disk/WindowsDiskMetrics.cs
Outdated
Show resolved
Hide resolved
...aries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Windows/Disk/WindowsDiskMetrics.cs
Outdated
Show resolved
Hide resolved
...t.Extensions.Diagnostics.ResourceMonitoring/Windows/Disk/WindowsDiskPerSecondPerfCounters.cs
Outdated
Show resolved
Hide resolved
|
Hi @makazeu , thanks for pickup up this task! I am busy with other things right now, could you please don't merge this until I have a chance to review it? Will try to review this or next week. Thanks! |
Sure, Evgeny. This is still a draft yet, I will not merge it until it has more unit tests and you have reviewed it. |
|
This PR is now ready for review! Edit: Add screenshosts for my tests with Grafana + Prometeus, and Geneva. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5842
Add the below new Windows metrics to the ResourceMonitoring library:
Will try to support below metrics in the future:
Also, will support Linux in the future
Tested in Grafana + Prometheus with OpenTelemetry.Exporter.Prometheus.HttpListener
Tested in Geneva with OpenTelemetry.Exporter.Geneva
Microsoft Reviewers: Open in CodeFlow