-
Notifications
You must be signed in to change notification settings - Fork 821
Allow typed bindings(and!) in CE without parentheses #18682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
and!
typed bindings
T-Gro
reviewed
Jul 21, 2025
T-Gro
reviewed
Jul 21, 2025
This is ready @T-Gro |
Thanks @edgarfgp for getting this in. |
T-Gro
approved these changes
Jul 29, 2025
/azn run |
Thanks @T-Gro. Can you please re-run the CI ?. Don't want to close a re-open the PR. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow computation expression (CE) bindings (
let!
,use!
,and!
) to accept type annotations without requiring parentheses.Continuation of #18508
Implements RFC FS-1329: fsharp/fslang-design#802
Introduces significant grammar unification:
bindingPatternWithOptType
andceBindingCore
mkLetExpression
andmkAndBang
AllowTypedLetUseAndBang
The above rule unification will allow us to remove in a separate PR
LetOrUseBang
, adding boolenisComputed
property(true for let!/use!, false for let/use) toLetOrUse
.Checklist