Fix ref-assembly MVID collisions from truncating signature-hash combiner - #20392
Open
T-Gro wants to merge 4 commits into
Open
Fix ref-assembly MVID collisions from truncating signature-hash combiner#20392T-Gro wants to merge 4 commits into
T-Gro wants to merge 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…isions (#20389) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
Warning No PR link found in some release notes, please consider adding it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20389
Reference-assembly MVIDs collided when a public member was renamed in an early file of a large (>~32 file) project under
--optimize-: the per-file signature hashes were folded with a left-shift-by-one combiner over a 32-bitHash, truncating the contribution of any file more than ~32 positions from the end of the compile order, soCopyRefAssemblykept a stale reference assembly (surfacing downstream asFS0039). The combiner is now an FNV-1a multiply mix over a 64-bitHash.